Skip to content

Commit d0a91b9

Browse files
authored
FreeBSD: Reduce copy_file_range() source lock to shared
Linux locks copy_file_range() source as shared. FreeBSD was doing it also, but then was changed to exclusive, partially because KPI of that time was doing so, and partially seems out of caution. Considering zfs_clone_range() uses range locks on both source and destination, neither should require exclusive vnode locks. But one step at a time, just sync it with Linux for now. Reviewed-by: Alan Somers <asomers@gmail.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alexander Motin <mav@FreeBSD.org> Sponsored by: iXsystems, Inc. Closes openzfs#16789 Closes openzfs#16797
1 parent b3b0ce6 commit d0a91b9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

module/os/freebsd/zfs/zfs_vnops_os.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6202,7 +6202,7 @@ zfs_freebsd_copy_file_range(struct vop_copy_file_range_args *ap)
62026202
} else {
62036203
#if (__FreeBSD_version >= 1302506 && __FreeBSD_version < 1400000) || \
62046204
__FreeBSD_version >= 1400086
6205-
vn_lock_pair(invp, false, LK_EXCLUSIVE, outvp, false,
6205+
vn_lock_pair(invp, false, LK_SHARED, outvp, false,
62066206
LK_EXCLUSIVE);
62076207
#else
62086208
vn_lock_pair(invp, false, outvp, false);

0 commit comments

Comments
 (0)