Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance Tests #109

Open
CWSpear opened this issue Apr 28, 2015 · 2 comments
Open

Acceptance Tests #109

CWSpear opened this issue Apr 28, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@CWSpear
Copy link
Collaborator

CWSpear commented Apr 28, 2015

As part of #69, in addition to some tests with Karma, etc, we really need some solid Acceptance Tests to handle cross browser quirks.

Specifically, the issue(s) plaguing us:

  • Mobile devices: Mobile devices don't have hover events. We want mobile devices to only activate dropdowns on touch. Furthermore, we need to consider how we want to handle "clicking" on the parent in these scenarios (a highly requested feature. See Is it possible to make the parent clickable #27 and Question re: making parent menu links clickable #16).
  • Touch enabled desktops: As per the last issue, it isn't enough to disable hover events if the devices has touch events, because Windows 8 desktops have touch enabled and still have a mouse. We want these dropdowns to work on hover.
  • Cross browser/device quirks: For example, I haven't been able to verify, but I've gotten multiple reports of weird stuff going on on Windows Phones: Menus automatically closing on Windows Phone 8 #28
@CWSpear CWSpear added this to the v3.0 milestone Apr 28, 2015
@CWSpear
Copy link
Collaborator Author

CWSpear commented Apr 28, 2015

I have a BrowerStack account that we can use for testing.

@CWSpear
Copy link
Collaborator Author

CWSpear commented Apr 28, 2015

I'm not 100% sure, but Pointer Events (à la jQuery's PEP) may help. All major browsers except Safari have recently committed to implementing this natively (i.e. see this thread).

(Note, this is not the same thing as pointer-events: none; (well, actually, I think they may be related, but it's much more than just that). See the PEP thing for more, but it's a series of events that should better handle issues with click vs touch.)

@CWSpear CWSpear added the ready label Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants