Don't do anything when navbar is collapsed #136
Comments
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this issue
Nov 21, 2015
disabled the hover popup when the navbar is collapsed. See mdbootstrap/bootstrap-hover-dropdown#136 for the issue I created about this. fixes thewca#210, fixes thewca#236
|
It's normally a non-issue (since typically, people don't have the screen that small on desktop), but I think that's an alright thing to include. |
|
Haha, for sure, people don't have screens that small, but it's not unheard of for me to make my windows that small! I've created a PR here. Entering the realm of truly crazy arguments: it's also possible to plug a mouse into your phone. |
|
Our biggest issue right now are those hybrid desktop Windows machines that have touch screens. There is some promise with PointerEvents, but it has some drawbacks as well poor browser support (but all the major vendors have said they'd support it eventually). |
jfly
added a commit
to jfly/worldcubeassociation.org
that referenced
this issue
Nov 24, 2015
disabled the hover popup when the navbar is collapsed. See mdbootstrap/bootstrap-hover-dropdown#136 for the issue I created about this. fixes thewca#210, fixes thewca#236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I find it very hard to use a collapsed navbar with this plugin. I think it's better to not do anything when the navbar is collapsed. I added a simple test for if the navbar is collapsed in jfly@f426275. I am happy to submit a PR if interested!
The text was updated successfully, but these errors were encountered: