style(Frontend): 🎨 clippy

Author: KAIYOHUGO

frontend/src/components/editor.rs

@@ -79,8 +79,7 @@ pub fn Editor(
 
         let config = Object::new();
         Reflect::set(&config, &"theme".into(), &"vs-dark".into()).unwrap();
-        Reflect::set(&config, &"automaticLayout".into(), &true.into())
-            .unwrap();
+        Reflect::set(&config, &"automaticLayout".into(), &true.into()).unwrap();
 
         let init_monaco = Closure::once_into_js(move || {
             let editor = MONACO.editor().create_editor(
@@ -98,7 +97,7 @@ pub fn Editor(
 
     create_effect(move |_| {
         editor_ref.with(|editor| {
-            let Some(model) = editor.as_ref().map(|e| e.get_model()).flatten()
+            let Some(model) = editor.as_ref().and_then(|e| e.get_model())
             else {
                 return;
             };

frontend/src/components/paginate_navbar.rs

@@ -80,7 +80,7 @@ fn PaginateNavbarButton(
             class=move || {
                 tw_join!(
                     "size-8",
-                    disabled().then_some("bg-primary disabled").unwrap_or("bg-black-900")
+                    if disabled() { "bg-primary disabled" } else { "bg-black-900" }
                 )
             }
         >

frontend/src/components/toast.rs

@@ -105,7 +105,7 @@ fn Toast(
         is_pending,
         ..
     } = {
-        let close = close.clone();
+        let close = close;
         use_timeout_fn(move |_| close(), 4.0 * 1000.0)
     };
 

frontend/src/utils/config.rs

@@ -91,18 +91,12 @@ impl Default for FrontendConfig {
     }
 }
 
-#[derive(Debug, PartialEq, Eq, Clone, Deserialize, Serialize)]
+#[derive(Debug, PartialEq, Eq, Clone, Deserialize, Serialize, Default)]
 pub struct BackendConfig {
     #[serde(default)]
     pub trust_xff: bool,
 }
 
-impl Default for BackendConfig {
-    fn default() -> Self {
-        Self { trust_xff: false }
-    }
-}
-
 #[cfg(feature = "ssr")]
 pub async fn init_config() -> Result<()> {
     let config = load_config().await?;

frontend/src/utils/grpc.rs

@@ -59,6 +59,7 @@ where
 #[cfg(feature = "ssr")]
 fn with_xff(metadata: MetadataMap) -> MetadataMap {
     use actix_web::http::header;
+    use leptos::*;
     use leptos_actix::ResponseOptions;
 
     let mut header_map = metadata.into_headers();

frontend/src/utils/router.rs

@@ -43,7 +43,7 @@ where
     }
 
     fn convert_to_type(s: &str) -> Option<Self::Output> {
-        s.parse().ok().map(|n| T::try_from(n).ok()).flatten()
+        s.parse().ok().and_then(|n| T::try_from(n).ok())
     }
 
     fn convert_to_string(o: Self::Output) -> String {
@@ -57,7 +57,7 @@ where
 
 impl<T: QueryType> Clone for ParamsMapKey<T> {
     fn clone(&self) -> Self {
-        Self(self.0.clone())
+        Self(self.0)
     }
 }
 
@@ -75,7 +75,7 @@ impl<T: QueryType> Clone for InnerParamsMapKey<T> {
         Self {
             key: self.key,
             default: self.default.clone(),
-            _maker: self._maker.clone(),
+            _maker: self._maker,
         }
     }
 }
@@ -136,7 +136,7 @@ impl MemoParamsMapExtra for Memo<ParamsMap> {
         &self,
         f: impl Fn(&mut ParamsMap) + 'static,
     ) -> Signal<String> {
-        let map = self.clone();
+        let map = *self;
         Signal::derive(move || {
             let mut map = map();
             f(&mut map);
@@ -159,15 +159,15 @@ impl MemoParamsMapExtra for Memo<ParamsMap> {
         &self,
         query: ParamsMapKey<T>,
     ) -> Signal<Option<T::Output>> {
-        let map = self.clone();
+        let map = *self;
         Signal::derive(move || map().get_query(query))
     }
 
     fn use_query_with_default<T: QueryType>(
         &self,
         query: ParamsMapKey<T>,
     ) -> Signal<T::Output> {
-        let map = self.clone();
+        let map = *self;
         Signal::derive(move || map().get_query_with_default(query))
     }
 }
@@ -196,9 +196,7 @@ impl ParamsMapExtra for ParamsMap {
     where
         T: QueryType,
     {
-        self.get(query.key())
-            .map(|v| T::convert_to_type(v))
-            .flatten()
+        self.get(query.key()).and_then(|v| T::convert_to_type(v))
     }
 
     fn get_query_with_default<T>(&self, query: ParamsMapKey<T>) -> T::Output
@@ -213,11 +211,9 @@ impl ParamsMapExtra for ParamsMap {
     where
         T: QueryType,
     {
-        let value = value
-            .map(move |v| {
-                query.0.with_value(|query| v != query.default).then_some(v)
-            })
-            .flatten();
+        let value = value.and_then(move |v| {
+            query.0.with_value(|query| v != query.default).then_some(v)
+        });
         match value {
             Some(value) => {
                 self.insert(query.key().to_owned(), T::convert_to_string(value))

frontend/src/utils/session.rs

@@ -33,5 +33,5 @@ pub fn use_token() -> Signal<Option<String>> {
 
 pub fn use_role() -> Signal<Option<Role>> {
     let (user_info, _) = use_token_info();
-    (move || user_info().as_ref().map(|s| s.role.clone())).into_signal()
+    (move || user_info().as_ref().map(|s| s.role)).into_signal()
 }