Merge pull request #47 from christobill/CHORE/46-fatal-warnings

[#14] Set up fatal warnings compilation flag

Author: mdedetrich

.travis.yml

@@ -2,7 +2,7 @@ sudo: false
 language: scala
 scala:
   - 2.11.11
-  - 2.12.2
+  - 2.12.8
 jdk: oraclejdk8
 cache:
   directories:

build.sbt

@@ -1,6 +1,6 @@
 name := "stripe-scala"
 
-val currentScalaVersion = "2.12.3"
+val currentScalaVersion = "2.12.8"
 val scala211Version     = "2.11.11"
 val circeVersion        = "0.9.3"
 
@@ -11,6 +11,7 @@ crossScalaVersions := Seq(currentScalaVersion, scala211Version)
 organization := "org.mdedetrich"
 
 scalacOptions ++= Seq(
+  "-Xfatal-warnings",
   "-target:jvm-1.8",
   "-encoding",
   "UTF-8",
@@ -94,17 +95,16 @@ releaseProcess := Seq[ReleaseStep](
 )
 
 val flagsFor11 = Seq(
-  "-Xlint:_",
   "-Yconst-opt",
   "-Ywarn-infer-any",
   "-Yclosure-elim",
   "-Ydead-code"
 )
 
 val flagsFor12 = Seq(
-  "-Xlint:_",
+  "-Xlint:-unused", //because 2.11 needs unused import: cats.syntax.either._
   "-Ywarn-infer-any",
-  "-opt:l:project"
+  "-opt-inline-from:<sources>"
 )
 
 scalacOptions ++= {

src/main/scala/org/mdedetrich/stripe/v1/Accounts.scala

@@ -8,7 +8,6 @@ import akka.http.scaladsl.HttpExt
 import akka.stream.Materializer
 import cats.syntax.either._
 import com.typesafe.scalalogging.LazyLogging
-import defaults._
 import enumeratum.{Enum, EnumEntry}
 import io.circe._
 import io.circe.syntax._

src/main/scala/org/mdedetrich/stripe/v1/Balances.scala

@@ -171,9 +171,7 @@ object Balances extends LazyLogging {
        x.status,
        x.`type`))
 
-  case class SourceTypes(card: Option[BigDecimal],
-                         bankAccount: Option[BigDecimal],
-                         bitcoinReceiver: Option[BigDecimal])
+  case class SourceTypes(card: Option[BigDecimal], bankAccount: Option[BigDecimal], bitcoinReceiver: Option[BigDecimal])
 
   implicit val sourceTypesDecoder: Decoder[SourceTypes] = Decoder.forProduct3(
     "card",

src/main/scala/org/mdedetrich/stripe/v1/BankAccounts.scala

@@ -5,7 +5,6 @@ import akka.http.scaladsl.model.Uri
 import akka.http.scaladsl.model.Uri.Query
 import akka.stream.Materializer
 import com.typesafe.scalalogging.LazyLogging
-import defaults._
 import enumeratum._
 import io.circe._
 import io.circe.syntax._

src/main/scala/org/mdedetrich/stripe/v1/Customers.scala

@@ -6,7 +6,6 @@ import akka.http.scaladsl.HttpExt
 import akka.http.scaladsl.model.Uri
 import akka.stream.Materializer
 import cats.syntax.either._
-import defaults._
 import com.typesafe.scalalogging.LazyLogging
 import io.circe._
 import io.circe.syntax._

src/main/scala/org/mdedetrich/stripe/v1/Errors.scala

@@ -2,10 +2,9 @@ package org.mdedetrich.stripe.v1
 
 import akka.http.scaladsl.model.HttpResponse
 import cats.instances.either._
-import cats.syntax.cartesian._
 import cats.syntax.either._
-import defaults._
 import enumeratum._
+import io.circe.Decoder.Result
 import io.circe._
 
 object Errors {
@@ -113,34 +112,38 @@ object Errors {
         extends Error(429, `type`, code, message, param)
   }
 
-  private def errorDecoder(c: HCursor) =
-    c.downField("type").as[Type] |@|
-      c.downField("code").as[Option[Code]] |@|
-      c.downField("message").as[Option[String]] |@|
-      c.downField("param").as[Option[String]].map {
-        case Some(s) if s.isEmpty => None
-        case s                    => s
-      }
+  private def errorDecoder(
+      c: HCursor): (Result[Type], Result[Option[Code]], Result[Option[String]], Result[Option[String]]) =
+    (c.downField("type").as[Type],
+     c.downField("code").as[Option[Code]],
+     c.downField("message").as[Option[String]],
+     c.downField("param").as[Option[String]].map {
+       case Some(s) if s.isEmpty => None
+       case s                    => s
+     })
+
+  import cats.syntax.apply._
+  import cats.instances.either._
 
   implicit val badRequestDecoder: Decoder[Error.BadRequest] =
     Decoder.instance[Error.BadRequest] { c =>
-      errorDecoder(c).map(Error.BadRequest.apply)
+      errorDecoder(c).mapN(Error.BadRequest.apply)
     }
   implicit val unauthorizedDecoder: Decoder[Error.Unauthorized] =
     Decoder.instance[Error.Unauthorized] { c =>
-      errorDecoder(c).map(Error.Unauthorized.apply)
+      errorDecoder(c).mapN(Error.Unauthorized.apply)
     }
   implicit val requestFailedDecoder: Decoder[Error.RequestFailed] =
     Decoder.instance[Error.RequestFailed] { c =>
-      errorDecoder(c).map(Error.RequestFailed.apply)
+      errorDecoder(c).mapN(Error.RequestFailed.apply)
     }
   implicit val notFoundDecoder: Decoder[Error.NotFound] =
     Decoder.instance[Error.NotFound] { c =>
-      errorDecoder(c).map(Error.NotFound.apply)
+      errorDecoder(c).mapN(Error.NotFound.apply)
     }
   implicit val tooManyRequestsDecoder: Decoder[Error.TooManyRequests] =
     Decoder.instance[Error.TooManyRequests] { c =>
-      errorDecoder(c).map(Error.TooManyRequests.apply)
+      errorDecoder(c).mapN(Error.TooManyRequests.apply)
     }
 
   private def errorEncoder: Encoder[Error] =

src/main/scala/org/mdedetrich/stripe/v1/PaymentSource.scala

@@ -8,7 +8,6 @@ import akka.http.scaladsl.model.Uri.Query
 import akka.stream.Materializer
 import cats.syntax.either._
 import com.typesafe.scalalogging.LazyLogging
-import defaults._
 import enumeratum._
 import io.circe._
 import io.circe.syntax._

src/main/scala/org/mdedetrich/stripe/v1/TransferReversals.scala

@@ -7,7 +7,6 @@ import akka.http.scaladsl.model.Uri
 import akka.http.scaladsl.model.Uri.Query
 import akka.stream.Materializer
 import com.typesafe.scalalogging.LazyLogging
-import defaults._
 import io.circe.{Decoder, Encoder}
 import org.mdedetrich.stripe.v1.defaults._
 import org.mdedetrich.stripe.{ApiKey, Endpoint, IdempotencyKey, PostParams}

src/main/scala/org/mdedetrich/stripe/v1/Transfers.scala

@@ -7,7 +7,6 @@ import akka.http.scaladsl.model.Uri
 import akka.stream.Materializer
 import cats.syntax.either._
 import com.typesafe.scalalogging.LazyLogging
-import defaults._
 import enumeratum._
 import io.circe.{Decoder, Encoder}
 import org.mdedetrich.stripe.v1.BankAccounts._