Treat empty but idle video state as not loading #141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when using the preload=none property on a video as a hint to avoid loading video contents on page load, the overlay is always a progress spinner. With this change play is shown instead. Also add tests for existing UA logic around loading status. Fixes: #132
bikkimahato
reviewed
Dec 26, 2021
| @@ -122,17 +122,26 @@ DefaultPlayer.propTypes = { | |||
| video: PropTypes.object.isRequired | |||
| }; | |||
|
|
|||
| function isLoading(readyState, networkState, userAgent) { | |||
| if (readyState == 0 && networkState == 1) { | |||
There was a problem hiding this comment.
Please use strict equality operator ===
There was a problem hiding this comment.
Thanks for the review!
Yes, this could use === though the eslint config of this project doesn't include the eqeqeq rule stating it must, and in practice callers are using the browser enums not null or other complicating values.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using the preload=none property on a video as a hint
to avoid loading video contents on page load, the overlay is always
a progress spinner. With this change play is shown instead.
Also add tests for existing UA logic around loading status.
Fixes: #132