Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

justify-all unsupported #36091

Closed
calebfoss opened this issue Sep 28, 2024 · 4 comments · Fixed by #36161
Closed

justify-all unsupported #36091

calebfoss opened this issue Sep 28, 2024 · 4 comments · Fixed by #36161
Labels
Content:CSS Cascading Style Sheets docs good first issue A good issue for newcomers to get started with.

Comments

@calebfoss
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/CSS/text-align

What specific section or headline is this issue about?

https://developer.mozilla.org/en-US/docs/Web/CSS/text-align#values

What information was incorrect, unhelpful, or incomplete?

This section lists justify-all as a valid value for this property, but attempting to use it in the example editor displays an X. On Firefox, I see that this value is invalid. It is not listed in the browser compatibility section.

What did you expect to see?

If justify-all is supported by some browsers, including that information would be very helpful. If not, it would be best to remove it.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@calebfoss calebfoss added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Sep 28, 2024
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Sep 28, 2024
@Josh-Cena
Copy link
Member

It is listed in the spec but none of the browsers implement it: https://wpt.fyi/results/?label=master&label=experimental&aligned&q=text-align-justifyall

I'm not sure what to do. My understanding is that BCD doesn't want to include features not implemented anywhere, and in principle the content should ignore it too, but the formal syntax is not controlled by us so it will be displayed there anyway, which may be even more confusing.

@calebfoss
Copy link
Author

Thank you for the explanation! Am I understanding correctly that because it's in the spec, it must be documented in the values section but because it has no support, should not be documented in the browser compatibility section? Would it be possible to include a note in the description of the value? Or in the general description for the property if not?

@Josh-Cena
Copy link
Member

The usual policy is that features not implemented anywhere would not get any mention on MDN, at least not masquerading as real references. However, the formal syntax block is pulled in from an external dataset w3c/webref, so it would be always displayed there, and our experience is that readers often get confused and say "why is this value in formal syntax but not documented anywhere". I'm not sure what we should do to be least confusing—my personal opinion is to add a row in the browser compat table with all "No", but I'm not sure if that fits BCD policies.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Sep 30, 2024

The correct MDN fix here is to remove text-align: justify-all; entirely from this page as unimplemented. Yes this will remain in the formal syntax, and yes that is confusing. That is the policy though.

"No", but I'm not sure if that fits BCD policies.

It doesn't fit with policy.

This has come up a bunch of time. IMO we should auto-add a note with formal syntax noting that this may contain values that are not implemented anywhere. But I'm not in charge.

I guess another way would be for yari to post-process the BCD and auto-add "not supported" for things that are in formal syntax or IDL but not supported in browsers.

@Josh-Cena Josh-Cena added help wanted If you know something about this topic, we would love your help! and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 1, 2024
@Josh-Cena Josh-Cena changed the title justify-all missing browser support justify-all unsupported Oct 1, 2024
@Josh-Cena Josh-Cena added good first issue A good issue for newcomers to get started with. and removed help wanted If you know something about this topic, we would love your help! labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs good first issue A good issue for newcomers to get started with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants