Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Does DELETE permit body? #23258

Open
sbouchard-spordle opened this issue Jul 8, 2024 · 3 comments · May be fixed by #24009
Open

[fr] Does DELETE permit body? #23258

sbouchard-spordle opened this issue Jul 8, 2024 · 3 comments · May be fixed by #24009
Labels
l10n-fr Issues related to French content.

Comments

@sbouchard-spordle
Copy link

sbouchard-spordle commented Jul 8, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/DELETE

What specific section or headline is this issue about?

DELETE

What information was incorrect, unhelpful, or incomplete?

My coworker and I had a discussion and since our office is bilingual (french and english) we noticed, after some arguing, that the information is different in the documentation depending on the language. I am not 100% sure which one is correct, but depending on the language you choose, the value for Request has body changes.

English:
Request has body: May (meaning that is is indeed possible and supported)

French:
La requête a un corps: Non (meaning that it is not possible)

Español:
Petición con cuerpo: Puede (If i'm not mistaken it means that it is possible and supported)

What did you expect to see?

Every languages needs to display the same correct information

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

@sbouchard-spordle sbouchard-spordle added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 8, 2024
@Josh-Cena
Copy link
Member

Interestingly this discrepancy has existed ever since MDN migrated to GitHub, so it's hard to tell which one was modified after translation. However, the spec for DELETE uses the exact same wording as for GET and HEAD:

Although request message framing is independent of the method used, content received in a DELETE request has no generally defined semantics, cannot alter the meaning or target of the request, and might lead some implementations to reject the request and close the connection because of its potential as a request smuggling attack.

However, fetch only rejects GET/HEAD with body, and not DELETE.

@Josh-Cena Josh-Cena changed the title Inconsistencies in HTTP DELETE documentation Does DELETE permit body? Jul 8, 2024
@Josh-Cena Josh-Cena added needs info This needs more information to review or act on. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jul 8, 2024
@bsmth
Copy link
Member

bsmth commented Jul 9, 2024

Thanks for reporting and to Josh for investigating. I would also add the next spec section for some more info:

A client SHOULD NOT generate content in a DELETE request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.

It is possible, although not generally good practice unless an implementation indicates it expects a body. So May have a body is accurate IMO and the FR translation is wrong here.

@Josh-Cena Josh-Cena added to move If the issue doesn't belong in translated-content but elsewhere in the MDN org and removed needs info This needs more information to review or act on. labels Aug 10, 2024
@Josh-Cena
Copy link
Member

Josh-Cena commented Aug 10, 2024

Marking it as https://github.com/mdn/content/labels/to%20move because the fr version is more wrong, but I think we should add the spec excerpt above to the three method pages.

@bsmth bsmth transferred this issue from mdn/content Aug 26, 2024
@bsmth bsmth changed the title Does DELETE permit body? [fr] Does DELETE permit body? Aug 26, 2024
@bsmth bsmth added l10n-fr Issues related to French content. and removed to move If the issue doesn't belong in translated-content but elsewhere in the MDN org labels Aug 26, 2024
SphinxKnight added a commit to SphinxKnight/translated-content that referenced this issue Oct 13, 2024
@SphinxKnight SphinxKnight linked a pull request Oct 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants