restore original test data after testing backup restores

Author: michael-genson

tests/unit_tests/services_tests/backup_v2_tests/test_backup_v2.py

@@ -93,55 +93,61 @@ def test_database_restore_data(backup_path: Path):
     settings = get_app_settings()
     backup_v2 = BackupV2(settings.DB_URL)
 
-    assert backup_path.exists()
-    backup_v2.restore(backup_path)
-
-    # make sure migrations populated data successfully
-    with session_context() as session:
-        session = cast(Session, session)
-
-        groups = session.query(Group).all()
-        recipes = session.query(RecipeModel).all()
-        shopping_lists = session.query(ShoppingList).all()
-        labels = session.query(MultiPurposeLabel).all()
-
-        foods = session.query(IngredientFoodModel).all()
-        units = session.query(IngredientUnitModel).all()
-
-        # 2023-02-14-20.45.41_5ab195a474eb_add_normalized_search_properties
-        for recipe in recipes:
-            if recipe.name:
-                assert recipe.name_normalized
-            if recipe.description:
-                assert recipe.description_normalized
-
-            for ingredient in recipe.recipe_ingredient:
-                if ingredient.note:
-                    assert ingredient.note_normalized
-                if ingredient.original_text:
-                    assert ingredient.original_text_normalized
-
-        # 2023-02-21-22.03.19_b04a08da2108_added_shopping_list_label_settings
-        for shopping_list in shopping_lists:
-            group_labels = [label for label in labels if label.group_id == shopping_list.group_id]
-            assert len(shopping_list.label_settings) == len(group_labels)
-            for label_setting, label in zip(
-                sorted(shopping_list.label_settings, key=lambda x: x.label.id),
-                sorted(group_labels, key=lambda x: x.id),
-                strict=True,
-            ):
-                assert label_setting.label == label
-
-        # 2023-08-06-21.00.34_04ac51cbe9a4_added_group_slug
-        for group in groups:
-            assert group.slug
-
-        # 2023-09-01-14.55.42_0341b154f79a_added_normalized_unit_and_food_names
-        for food in foods:
-            if food.name:
-                assert food.name_normalized
-
-        for unit in units:
-            assert unit.name_normalized
-            if unit.abbreviation:
-                assert unit.abbreviation_normalized
+    # create a backup of the existing data so we can restore it later
+    original_data_backup = backup_v2.backup()
+
+    try:
+        assert backup_path.exists()
+        backup_v2.restore(backup_path)
+
+        # make sure migrations populated data successfully
+        with session_context() as session:
+            session = cast(Session, session)
+
+            groups = session.query(Group).all()
+            recipes = session.query(RecipeModel).all()
+            shopping_lists = session.query(ShoppingList).all()
+            labels = session.query(MultiPurposeLabel).all()
+
+            foods = session.query(IngredientFoodModel).all()
+            units = session.query(IngredientUnitModel).all()
+
+            # 2023-02-14-20.45.41_5ab195a474eb_add_normalized_search_properties
+            for recipe in recipes:
+                if recipe.name:
+                    assert recipe.name_normalized
+                if recipe.description:
+                    assert recipe.description_normalized
+
+                for ingredient in recipe.recipe_ingredient:
+                    if ingredient.note:
+                        assert ingredient.note_normalized
+                    if ingredient.original_text:
+                        assert ingredient.original_text_normalized
+
+            # 2023-02-21-22.03.19_b04a08da2108_added_shopping_list_label_settings
+            for shopping_list in shopping_lists:
+                group_labels = [label for label in labels if label.group_id == shopping_list.group_id]
+                assert len(shopping_list.label_settings) == len(group_labels)
+                for label_setting, label in zip(
+                    sorted(shopping_list.label_settings, key=lambda x: x.label.id),
+                    sorted(group_labels, key=lambda x: x.id),
+                    strict=True,
+                ):
+                    assert label_setting.label == label
+
+            # 2023-08-06-21.00.34_04ac51cbe9a4_added_group_slug
+            for group in groups:
+                assert group.slug
+
+            # 2023-09-01-14.55.42_0341b154f79a_added_normalized_unit_and_food_names
+            for food in foods:
+                if food.name:
+                    assert food.name_normalized
+
+            for unit in units:
+                assert unit.name_normalized
+                if unit.abbreviation:
+                    assert unit.abbreviation_normalized
+    finally:
+        backup_v2.restore(original_data_backup)