Feature Request: V1 - Add SSL Email Support #1218
Replies: 3 comments
-
I think there is tech debt that could be picked up with this too, if authentication is 'none' then don't expect an SMTP user and password. You probably also could move the 'smtp_tls' variable out of the required check and just let it default to false. |
Beta Was this translation helpful? Give feedback.
-
I think 2 is a good option. I'm okay with the breaking change. I wonder if there's a way to fallback to the TLS setting if we don't detect an SMTP_AUTH_STRATEGY? I also agree that there's some other technical debt in there. Let me know if you need anything else to get started on this one. |
Beta Was this translation helpful? Give feedback.
-
Hey @hay-kot, I created a PR ( #1235 ) for this, I left a couple preliminary questions in there. |
Beta Was this translation helpful? Give feedback.
-
Before submitting this feature request I have
COMPLETE AND FILL THESE OUT
Please Describe The Problem To Be Solved
Essentially my email server/setup uses the standard email protocol SSL/port 465. It looks like mealie supports SmartTLS and unauthenticated email, just not authenticated SSL SMTP.
(Optional): Suggest A Solution
I'm not super proficient in python, but I think this would be relatively easy to implement:
dict
value of'ssl': True
. It looks like that could go somewhere around here.SMTP_SSL
and would need to be added to the constructor and also the docs & docker compose files. There should probably be logic that does not allow bothSMTP_TLS
andSMTP_TLS
to both be true.I think there is also an opportunity for creating a better developer experience by changing the email authentication strategy to a single environment variable:
SMTP_AUTH_STRATEGY
(for example), that takes eitherNone
(default),TLS
, orSSL
. That may be a bigger change since that would break any current users. You could probably do something where if someone set TLS = true you use that to default SMTP_AUTH to TLS, but again that depends on how you want to transition support for this.Additional Information
-> Sure, I would want to know which of the above two strategies you want this to go. :)
Beta Was this translation helpful? Give feedback.
All reactions