Can't Favorite recipes

[jecorn]

I have a weird situation in my main mealie instance. Somehow I can't Favorite recipes and instead get an Internal Server Error. This current instance is migrated from sqlite to postgres, and there are previously Favorited recipes. But I can't Favorite anything new. I tried setting up a new instance and found that Favoriting works, so something weird happened during migration.

Whenever I click the Favorite button on a recipe, the following Internal Server Error hits the command line:

mealie-api-pg       | INFO:     172.26.0.4:41978 - "POST /api/users/5dfa0c82-f7fe-4900-bd5b-0215ad2151fa/favorites/ultimate-vegan-ramen-with-miso-broth-recipe HTTP/1.1" 500 Internal Server Error
mealie-api-pg       | ERROR:    Exception in ASGI application
mealie-api-pg       | Traceback (most recent call last):
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 436, in run_asgi
mealie-api-pg       |     result = await app(  # type: ignore[func-returns-value]
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
mealie-api-pg       |     return await self.app(scope, receive, send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/applications.py", line 276, in __call__
mealie-api-pg       |     await super().__call__(scope, receive, send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/applications.py", line 122, in __call__
mealie-api-pg       |     await self.middleware_stack(scope, receive, send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in __call__
mealie-api-pg       |     raise exc
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in __call__
mealie-api-pg       |     await self.app(scope, receive, _send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/gzip.py", line 24, in __call__
mealie-api-pg       |     await responder(scope, receive, send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/gzip.py", line 44, in __call__
mealie-api-pg       |     await self.app(scope, receive, self.send_with_gzip)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in __call__
mealie-api-pg       |     raise exc
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in __call__
mealie-api-pg       |     await self.app(scope, receive, sender)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
mealie-api-pg       |     raise e
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
mealie-api-pg       |     await self.app(scope, receive, send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 718, in __call__
mealie-api-pg       |     await route.handle(scope, receive, send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
mealie-api-pg       |     await self.app(scope, receive, send)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
mealie-api-pg       |     response = await func(request)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/routing.py", line 237, in app
mealie-api-pg       |     raw_response = await run_endpoint_function(
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/fastapi/routing.py", line 165, in run_endpoint_function
mealie-api-pg       |     return await run_in_threadpool(dependant.call, **values)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/starlette/concurrency.py", line 41, in run_in_threadpool
mealie-api-pg       |     return await anyio.to_thread.run_sync(func, *args)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/anyio/to_thread.py", line 31, in run_sync
mealie-api-pg       |     return await get_asynclib().run_sync_in_worker_thread(
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 937, in run_sync_in_worker_thread
mealie-api-pg       |     return await future
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 867, in run
mealie-api-pg       |     result = context.run(func, *args)
mealie-api-pg       |   File "/app/mealie/routes/users/favorites.py", line 27, in add_favorite
mealie-api-pg       |     self.repos.users.update(self.user.id, self.user)
mealie-api-pg       |   File "/app/mealie/repos/repository_generic.py", line 203, in update
mealie-api-pg       |     self.session.commit()
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 1903, in commit
mealie-api-pg       |     trans.commit(_to_root=True)
mealie-api-pg       |   File "<string>", line 2, in commit
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/state_changes.py", line 137, in _go
mealie-api-pg       |     ret_value = fn(self, *arg, **kw)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 1218, in commit
mealie-api-pg       |     self._prepare_impl()
mealie-api-pg       |   File "<string>", line 2, in _prepare_impl
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/state_changes.py", line 137, in _go
mealie-api-pg       |     ret_value = fn(self, *arg, **kw)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 1193, in _prepare_impl
mealie-api-pg       |     self.session.flush()
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 4155, in flush
mealie-api-pg       |     self._flush(objects)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 4291, in _flush
mealie-api-pg       |     with util.safe_reraise():
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/util/langhelpers.py", line 147, in __exit__
mealie-api-pg       |     raise exc_value.with_traceback(exc_tb)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/session.py", line 4252, in _flush
mealie-api-pg       |     flush_context.execute()
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/unitofwork.py", line 464, in execute
mealie-api-pg       |     n.execute_aggregate(self, set_)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/unitofwork.py", line 733, in execute_aggregate
mealie-api-pg       |     dependency_processor.process_saves(uow, states)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/dependency.py", line 1140, in process_saves
mealie-api-pg       |     if not self._synchronize(
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/dependency.py", line 1256, in _synchronize
mealie-api-pg       |     self._verify_canload(child)
mealie-api-pg       |   File "/opt/pysetup/.venv/lib/python3.10/site-packages/sqlalchemy/orm/dependency.py", line 261, in _verify_canload
mealie-api-pg       |     raise exc.FlushError(
mealie-api-pg       | sqlalchemy.orm.exc.FlushError: Can't flush None value found in collection User.favorite_recipes
/

[michael-genson]

This is an older discussion, so hopefully you've solved this by now. If you're still running into this, feel free to open an issue