Skip to content

Commit f7f2099

Browse files
systemtrapMatthias BERNDT
authored andcommitted
Fix Duplicate Badges
BadgeServiceImpl#saveNewBadgesFromIssueList filters already issued badges by an incorrect key resulting in issuing the same badge for each data retrieval cycle.
1 parent 7717929 commit f7f2099

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

sonar-connector/src/main/java/com/thepracticaldeveloper/devgame/modules/badges/calculators/UnitTesterBronzeBadgeCalculator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class UnitTesterBronzeBadgeCalculator implements BadgeCalculator {
2222

2323
@Override
2424
public String badgeKey() {
25-
return "UT_BRONZE";
25+
return KEY;
2626
}
2727

2828
@Override

sonar-connector/src/main/java/com/thepracticaldeveloper/devgame/modules/badges/calculators/UnitTesterGoldBadgeCalculator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class UnitTesterGoldBadgeCalculator implements BadgeCalculator {
2222

2323
@Override
2424
public String badgeKey() {
25-
return "UT_GOLD";
25+
return KEY;
2626
}
2727

2828
@Override

sonar-connector/src/main/java/com/thepracticaldeveloper/devgame/modules/badges/calculators/UnitTesterPaperBadgeCalculator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class UnitTesterPaperBadgeCalculator implements BadgeCalculator {
2222

2323
@Override
2424
public String badgeKey() {
25-
return "UT_PAPER";
25+
return KEY;
2626
}
2727

2828
@Override

sonar-connector/src/main/java/com/thepracticaldeveloper/devgame/modules/badges/calculators/UnitTesterSilverBadgeCalculator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class UnitTesterSilverBadgeCalculator implements BadgeCalculator {
2222

2323
@Override
2424
public String badgeKey() {
25-
return "UT_SILVER";
25+
return KEY;
2626
}
2727

2828
@Override

0 commit comments

Comments
 (0)