Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to prevent creation of duplicate sources #658

Open
rahulbot opened this issue Jun 10, 2024 · 0 comments
Open

need to prevent creation of duplicate sources #658

rahulbot opened this issue Jun 10, 2024 · 0 comments
Labels
bug Something isn't working directory high High priority

Comments

@rahulbot
Copy link
Collaborator

I was able to create a duplicate source without any errors. Our system relies on the idea that source name (the root URL) is mostly unique. Steps to reproduce:

  1. note that "jweekly.com" already exists at https://search.mediacloud.org/sources/29047
  2. create a new source with name set to "jweekly.com" and some notes and a label
  3. click save

Since neither 29047 or the new one has url_search_string this should have thrown an error preventing me from creating a duplicate source. Instead, I was able to create it. If one of them had a url_search_string set it should have let me create the source to allow for our small list of exception cases.

@rahulbot rahulbot added bug Something isn't working directory medium medium priority labels Jun 10, 2024
@pgulley pgulley added high High priority and removed medium medium priority labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working directory high High priority
Projects
None yet
Development

No branches or pull requests

2 participants