Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show warning on "child" sources indicating they shouldn't have RSS feeds #659

Open
rahulbot opened this issue Jun 10, 2024 · 1 comment
Open
Labels
directory enhancement New feature or request medium medium priority

Comments

@rahulbot
Copy link
Collaborator

We do allow multiple sources with the same name, iff they have a url_search_string set. Those are "child" or "placeholder" sources. We've decided a while ago that these "child" sources should not have RSS feeds one them... those should be kept on the "parent" source, the one that has the same name but no url_search_string set. I suggest adding a warning to help enforce this:

  1. when you click "refetch feeds" on a child source (ie. one with a url_search_string the confirmation popup should have a ⚠️ that says "BAD IDEA - keep all RSS feeds on the parent source"
  2. the "list feeds" and "create feeds" should show the same note as a banner under their header

This will hopefully help enforce the policy, but still the leave option open for the wierd-o one-offs we always end up having to for some reason or another.

@rahulbot rahulbot added enhancement New feature or request directory labels Jun 10, 2024
@pgulley pgulley added the medium medium priority label Jun 28, 2024
@philbudne
Copy link
Contributor

Just noticed this; Seems to me a corollary to this is that a rescrape of an entire collection should skip sources with a url_search_string! If so, perhaps open a separate issue for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory enhancement New feature or request medium medium priority
Projects
None yet
Development

No branches or pull requests

3 participants