From 96055c46d28587232e4a4e42ee55126aaa9d5766 Mon Sep 17 00:00:00 2001
From: Marcel Frankruijter <marcel.frankruijter@mediact.nl>
Date: Thu, 17 May 2018 15:34:53 +0200
Subject: [PATCH 1/2] Feature: improved coding standard

In this commit the coding standard is adjusted to be more strict.
Property declaration starting with an underscore is not allowed anymore, because the classes that are written internally should always abide to this standard.
The stricter indentation rules will make the overall code look cleaner and be more readable.
The generic syntax rule is for verifying that the code at least works.
---
 src/MediactMagento2/ruleset.xml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/MediactMagento2/ruleset.xml b/src/MediactMagento2/ruleset.xml
index e8b2326..6ff081e 100644
--- a/src/MediactMagento2/ruleset.xml
+++ b/src/MediactMagento2/ruleset.xml
@@ -17,12 +17,7 @@
         <exclude name="MediactCommon.Php7.ReturnType" />
         <exclude name="Squiz.Commenting.FunctionComment.TypeHintMissing" />
         <exclude name="PSR2.Methods.MethodDeclaration.Underscore" />
-        <exclude name="PSR2.Classes.PropertyDeclaration.Underscore" />
         <exclude name="Squiz.Commenting.FunctionComment.EmptyThrows" />
-        <exclude name="Generic.Formatting.MultipleStatementAlignment.NotSameWarning" />
-        <exclude name="Generic.Commenting.DocComment.TagValueIndent" />
-        <exclude name="Squiz.Commenting.FunctionComment.SpacingAfterParamType" />
-        <exclude name="Generic.PHP.Syntax"/>
     </rule>
 
     <rule ref="Generic.Files.LineLength.TooLong">

From c692181fa80931f3f967de0701885849e6989add Mon Sep 17 00:00:00 2001
From: Marcel Frankruijter <marcel.frankruijter@mediact.nl>
Date: Thu, 24 May 2018 15:16:20 +0200
Subject: [PATCH 2/2] Feedback: added exception

Added an exception for the template files for the underscore rule.
---
 src/MediactMagento2/ruleset.xml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/MediactMagento2/ruleset.xml b/src/MediactMagento2/ruleset.xml
index 6ff081e..4ed6edf 100644
--- a/src/MediactMagento2/ruleset.xml
+++ b/src/MediactMagento2/ruleset.xml
@@ -35,4 +35,7 @@
     <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed">
         <exclude-pattern>*.phtml</exclude-pattern>
     </rule>
+    <rule ref="PSR2.Classes.PropertyDeclaration.Underscore">
+        <exclude-pattern>*.phtml</exclude-pattern>
+    </rule>
 </ruleset>