-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest enketo-core #7599
Comments
Note that we will need to pay attention to enketo/enketo#82 since those changes will almost certainly require some changes to how we are handling saving the |
The current CHT/Enketo has a weird behavior (described in this forum thread) where some kind of weird conflict occurs when a calculating a To recreate the issue, make a form with the following: survey:
�choices:
Then upload the form to a CHT instance and follow these steps:
This broken behavior does not happen when just choosing |
Bumping to 4.4.0 as we're almost ready to release 4.3.0 and this has more work needed yet. |
Quick recap of what happened so far:
Now all tests are passing, even the ones included in #8480 - I merged them in a temporary branch just to make sure that they would pass in CI Here is what the next steps look like:
Calling in @jkuester @tatilepizs for anything I might have missed |
Make sure the release notes include graphs of the performance improvements this brings. This is probably just based on these graphs: https://forum.communityhealthtoolkit.org/t/feature-testing-enketo-7-uplift-for-cht-core/3196/2 |
Changed to a "performance" improvement as this has been measured to provide noticeable gains. |
Describe the issue
Not to be confused with #6345 which is upgrading to enketo-core to
^5.18.1
, this issue is for upgrading to the next latest version of Enekto (since it already contains several fixes that we know we would like).Describe the improvement you'd like
Once we have upgraded to the latest enketo-core, these are no longer necessary (since they are included in the new Eneketo code) and can be removed:
The text was updated successfully, but these errors were encountered: