-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change display and translations structure for criteria and concepts #382
Comments
After a quick discussion we decided to slightly change the format (the internal one for elastic search) so we do not use an array for translations. Since this would introduce a need for nested field type, which brings some restrictions, for which I honestly can't estimate if it will be a bigger deal in the future. So for now we will keep it simple. |
michael-82
added a commit
that referenced
this issue
Oct 18, 2024
…cepts - remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored)
michael-82
added a commit
that referenced
this issue
Oct 18, 2024
…cepts - Change responses to codeable concept and terminology replies to the new structure - missing: tests, actual ontology files to conveniently check if responses make sense
michael-82
added a commit
that referenced
this issue
Oct 18, 2024
…cepts - fix wrong field names (was in wrong case) for translations
michael-82
added a commit
that referenced
this issue
Oct 21, 2024
…cepts - remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored)
michael-82
added a commit
that referenced
this issue
Oct 21, 2024
…cepts - Change responses to codeable concept and terminology replies to the new structure - missing: tests, actual ontology files to conveniently check if responses make sense
michael-82
added a commit
that referenced
this issue
Oct 21, 2024
…cepts - fix wrong field names (was in wrong case) for translations
michael-82
added a commit
that referenced
this issue
Oct 21, 2024
…cepts - adapt tests to the new structure
michael-82
added a commit
that referenced
this issue
Oct 21, 2024
…cepts - modify swagger file to match new responses
michael-82
added a commit
that referenced
this issue
Oct 22, 2024
…cepts - remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored) - modify swagger file to match new responses - adapt tests to the new structure - Change responses to codeable concept and terminology replies to the new structure
michael-82
added a commit
that referenced
this issue
Oct 24, 2024
…cepts - remove nested declaration from elastic search documents (seems to be unnecessary, but should be monitored) - modify swagger file to match new responses - adapt tests to the new structure - Change responses to codeable concept and terminology replies to the new structure
"display": {
"original": "MII PR Medikation MedicationRequest",
"translations": [
{
"language": "de-DE",
"value": ""
},
{
"language": "en-US",
"value": "MII PR Medikation MedicationRequest"
}
]
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the translation structure should be change to allow for distinguishing between original display values and translations by language.
This should be changed for the criteria search and the concept search alike.
For the ontology index (criteria search) the display replaces the attribute "name".
When delivering this via the rest api however, the "display" object will be converted so it matches the format introduced in #381
The text was updated successfully, but these errors were encountered: