#415 - Make fhir client timeouts configurable #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
michael-82
commented
Dec 12, 2024
michael-82
commented
- introduce env variables for connect, socket and connectionRequest timeouts in the fhir client
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #416 +/- ##
=============================================
+ Coverage 78.54% 78.61% +0.07%
Complexity 558 558
=============================================
Files 138 138
Lines 2419 2427 +8
Branches 149 149
=============================================
+ Hits 1900 1908 +8
Misses 461 461
Partials 58 58 ☔ View full report in Codecov by Sentry. |
- introduce env variables for connect, socket and connectionRequest timeouts in the fhir client
michael-82
force-pushed
the
feature/415-make-fhir-client-timeouts-configurable
branch
from
7eb741f to
2233f96
Compare
|
@michael-82 , @alexanderkiel - is this not obsolete now if we execute cql asynchronosly?
|
|
For the Direct Broker @michael-82 you could implement async interaction yourself. @EmteZogaf does it only in the DSF plugin. Documentation von be found here. I would recommend to implement the async interaction over making the timeouts configurable. |
michael-82
deleted the
feature/415-make-fhir-client-timeouts-configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.