Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-flows): Allow create shipping methods through order edits #11560

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JohnGemstone
Copy link
Contributor

@JohnGemstone JohnGemstone commented Feb 21, 2025

Fixes for #11559 and #11558

Noticed there's a recent pull request #11504 which fixes what's passed to prepare-shipping-method.

As for updating the query for CreateOrderEditShippingMethodWorkflowInput entry point from order_claim to orders, it seems like this has already been fixed??

For my own education, how can github say I'm two commits ahead from the main develop branch but show what I'm merging into is different from the codebase...
See:
9fb265c

I can't even seem to find when this line was changed:
/packages/core/core-flows/src/order/workflows/order-edit/create-order-edit-shipping-method.ts#L118

What has happened?

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 905c999

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 21, 2025

@JohnGemstone is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant