Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset of the timezone separator does not follow the _default_ pattern #144

Open
meduzen opened this issue Jun 14, 2024 · 0 comments
Open
Labels
bug Something isn't working on hold Paused

Comments

@meduzen
Copy link
Owner

meduzen commented Jun 14, 2024

For all config methods, it’s possible to reset to the default settings by passing no parameter to it, this way you don’t have to think about it.

But setTzSeparator does not follow this pattern.

 // ✅ reset to the default value
setTimeSeparator()
setTzInRealWorldRange()
setTzConfig()

 // ❌ does not reset to the default value
setTzSeparator()

It could be considered as a bug but since it’s documented to work as it does today, it would be a breaking.

In addition, going to the default should maybe be a documented pattern.

The implementation using the Temporal API (#105) should also be adapted at the same time. In the meantime, since it’s an experimentation, it’s not needed to change it.

@meduzen meduzen added bug Something isn't working on hold Paused labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working on hold Paused
Projects
None yet
Development

No branches or pull requests

1 participant