You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For all config methods, it’s possible to reset to the default settings by passing no parameter to it, this way you don’t have to think about it.
But setTzSeparator does not follow this pattern.
// ✅ reset to the default valuesetTimeSeparator()setTzInRealWorldRange()setTzConfig()// ❌ does not reset to the default valuesetTzSeparator()
It could be considered as a bug but since it’s documented to work as it does today, it would be a breaking.
In addition, going to the default should maybe be a documented pattern.
The implementation using the Temporal API (#105) should also be adapted at the same time. In the meantime, since it’s an experimentation, it’s not needed to change it.
The text was updated successfully, but these errors were encountered:
For all config methods, it’s possible to reset to the default settings by passing no parameter to it, this way you don’t have to think about it.
But
setTzSeparator
does not follow this pattern.It could be considered as a bug but since it’s documented to work as it does today, it would be a breaking.
In addition, going to the default should maybe be a documented pattern.
The implementation using the Temporal API (#105) should also be adapted at the same time. In the meantime, since it’s an experimentation, it’s not needed to change it.
The text was updated successfully, but these errors were encountered: