Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there any plans for type annotations? #41

Open
sanjacob opened this issue Sep 16, 2024 · 3 comments
Open

Are there any plans for type annotations? #41

sanjacob opened this issue Sep 16, 2024 · 3 comments

Comments

@sanjacob
Copy link

I am willing to help out if necessary, to add type annotations to the whole library.
This would really benefit users who use type checkers in their CI pipelines.

Let me know what you think

@meeb
Copy link
Owner

meeb commented Sep 16, 2024

Sure I'm not opposed to the idea. Do people really type check third party libraries during CI builds? For Python especially that would seem like a nightmare.

@sanjacob
Copy link
Author

@meeb mypy benefits from having type annotations for third party libraries, e.g. if I call whoisit.ip(...) inside my own class then mypy will know if whatever I do with the result is valid.

@meeb
Copy link
Owner

meeb commented Sep 16, 2024

Fair enough that sounds sane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants