Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this going upstream ? #1

Open
gedw99 opened this issue Feb 24, 2023 · 9 comments
Open

is this going upstream ? #1

gedw99 opened this issue Feb 24, 2023 · 9 comments
Labels
question Further information is requested

Comments

@gedw99
Copy link

gedw99 commented Feb 24, 2023

💡 Feature/Idea

Hey @ProfessorManhattan

is this going upstream ? TUI seems like a nice feature :)

saw discussion here: go-task/task#700

👍 Can you contribute?

No response

@gedw99 gedw99 added the question Further information is requested label Feb 24, 2023
@ProfessorManhattan
Copy link
Contributor

ProfessorManhattan commented Feb 25, 2023

💡 Feature/Idea

Hey @ProfessorManhattan

is this going upstream ? TUI seems like a nice feature :)

saw discussion here: go-task/task#700

👍 Can you contribute?

_No res

@gedw99 I funded this project awhile ago and haven't gotten around to testing it. It'd be cool to have it merged upstream but it's missing a key feature - search. Are you a Go programmer / have you tried running this?

Looks like the search feature kinda works, you can filter the list but I was hoping for it to search through the descriptions and possibly summaries as well.

@gedw99
Copy link
Author

gedw99 commented Mar 21, 2023

Hey @ProfessorManhattan

I tested it just now.

Search ?? If you can explain what you mean i can have a look.

@ProfessorManhattan you can grab me here: https://github.com/gedw99

@ProfessorManhattan
Copy link
Contributor

I'll take a look later and show you what I mean. I was hoping to have it filter the list if you add a search string but I suppose this might be functional enough to propose as a POC to the task project maintainers

@gedw99
Copy link
Author

gedw99 commented Mar 22, 2023

Ok understand you…

Agree with you . better to just get something upstream and then iterate.

@ProfessorManhattan
Copy link
Contributor

Hey @gedw99 -- I just tested it and it looks like it's working... before merging it, I imagine we should remove the features that are not working (or add them in) like the tabs at the top. Also, I think we should add the command help menu items that are missing like the fact that you need to press tab to go through the tabs and press R to launch the task (which I'd like binded to return in conjuction --- perhaps R could also be used but I think pressing Enter is more intuitive for most).

Here's a video I made demonstrating the feature and describing what I had imagined for this project: https://www.youtube.com/watch?v=JrXFwbRUNIY

I originally had another developer work on this project and added a bunch of other features. Some documentation on the other features as well as the source code is available here: https://github.com/megabyte-labs/bodega

@gedw99
Copy link
Author

gedw99 commented Mar 22, 2023

nice . will check the video to get a gist of its flow.

@ProfessorManhattan
Copy link
Contributor

I just posted this issue too which is probably pretty important: #2

I think the issue might stem from fuller Taskfile.yml configurations where includes is being used to reference files in other directories.

@ProfessorManhattan
Copy link
Contributor

Also, just posted a topic here in go-task discussions: go-task/task#1077

@ProfessorManhattan
Copy link
Contributor

Hey @gedw99 .. would you be able to add any fixes for the issues I mentioned on the other thread? Like CTRL+C causing the process to hang and adding the commands to the bottom part of the menu? If you can do that, I can publish it to for use with Homebrew, Snap, and Docker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants