Update tests about the settings reset (#182)

Author: curquiza

meilisearch/tests/settings/test_settings_attributes_for_faceting_meilisearch.py

@@ -1,5 +1,7 @@
 # pylint: disable=invalid-name
 
+ATTRIBUTES_FOR_FACETING = ['title', 'release_date']
+
 def test_get_attributes_for_faceting(empty_index):
     """ Tests getting the attributes for faceting """
     response = empty_index().get_attributes_for_faceting()
@@ -8,19 +10,29 @@ def test_get_attributes_for_faceting(empty_index):
 
 def test_update_attributes_for_faceting(empty_index):
     """Tests updating the attributes for faceting"""
-    attributes_for_faceting = ['title', 'release_date']
     index = empty_index()
-    response = index.update_attributes_for_faceting(attributes_for_faceting)
+    response = index.update_attributes_for_faceting(ATTRIBUTES_FOR_FACETING)
     index.wait_for_pending_update(response['updateId'])
     get_attributes_new = index.get_attributes_for_faceting()
-    assert len(get_attributes_new) == len(attributes_for_faceting)
+    assert len(get_attributes_new) == len(ATTRIBUTES_FOR_FACETING)
     get_attributes = index.get_attributes_for_faceting()
-    for attribute in attributes_for_faceting:
+    for attribute in ATTRIBUTES_FOR_FACETING:
         assert attribute in get_attributes
 
 def test_reset_attributes_for_faceting(empty_index):
     """Tests the reset of attributes for faceting to default values (in dataset)"""
     index = empty_index()
+    # Update the settings first
+    response = index.update_attributes_for_faceting(ATTRIBUTES_FOR_FACETING)
+    update = index.wait_for_pending_update(response['updateId'])
+    assert update['status'] == 'processed'
+    # Check the settings have been correctly updated
+    get_attributes_new = index.get_attributes_for_faceting()
+    assert len(get_attributes_new) == len(ATTRIBUTES_FOR_FACETING)
+    get_attributes = index.get_attributes_for_faceting()
+    for attribute in ATTRIBUTES_FOR_FACETING:
+        assert attribute in get_attributes
+    # Check the reset of the settings
     response = index.reset_attributes_for_faceting()
     assert isinstance(response, object)
     assert 'updateId' in response

meilisearch/tests/settings/test_settings_displayed_attributes_meilisearch.py

@@ -27,6 +27,16 @@ def test_update_displayed_attributes(empty_index):
 def test_reset_displayed_attributes(empty_index):
     """Tests the reset of displayedAttributes to default values (in dataset)"""
     index = empty_index()
+    # Update the settings first
+    response = index.update_displayed_attributes(DISPLAYED_ATTRIBUTES)
+    update = index.wait_for_pending_update(response['updateId'])
+    assert update['status'] == 'processed'
+    # Check the settings have been correctly updated
+    get_attributes_new = index.get_displayed_attributes()
+    assert len(get_attributes_new) == len(DISPLAYED_ATTRIBUTES)
+    for attribute in DISPLAYED_ATTRIBUTES:
+        assert attribute in get_attributes_new
+    # Check the reset of the settings
     response = index.reset_displayed_attributes()
     assert isinstance(response, object)
     assert 'updateId' in response

meilisearch/tests/settings/test_settings_distinct_attribute_meilisearch.py

@@ -23,6 +23,15 @@ def test_update_distinct_attribute(empty_index):
 def test_reset_distinct_attribute(empty_index):
     """Tests resetting distinct attribute"""
     index = empty_index()
+    # Update the settings first
+    response = index.update_distinct_attribute(NEW_DISTINCT_ATTRIBUTE)
+    update = index.wait_for_pending_update(response['updateId'])
+    assert update['status'] == 'processed'
+    # Check the settings have been correctly updated
+    response = index.get_distinct_attribute()
+    assert isinstance(response, object)
+    assert response == NEW_DISTINCT_ATTRIBUTE
+    # Check the reset of the settings
     response = index.reset_distinct_attribute()
     assert isinstance(response, object)
     assert 'updateId' in response

meilisearch/tests/settings/test_settings_ranking_rules_meilisearch.py

@@ -31,6 +31,16 @@ def test_update_ranking_rules(empty_index):
 def test_reset_ranking_rules(empty_index):
     """Tests resetting the ranking rules"""
     index = empty_index()
+    # Update the settings first
+    response = index.update_ranking_rules(NEW_RANKING_RULES)
+    update = index.wait_for_pending_update(response['updateId'])
+    assert update['status'] == 'processed'
+    # Check the settings have been correctly updated
+    response = index.get_ranking_rules()
+    assert isinstance(response, object)
+    for rule in NEW_RANKING_RULES:
+        assert rule in response
+    # Check the reset of the settings
     response = index.reset_ranking_rules()
     assert isinstance(response, object)
     assert 'updateId' in response

meilisearch/tests/settings/test_settings_searchable_attributes_meilisearch.py

@@ -29,6 +29,16 @@ def test_update_searchable_attributes(empty_index):
 def test_reset_searchable_attributes(empty_index):
     """Tests reseting searchable attributes"""
     index = empty_index()
+    # Update the settings first
+    response = index.update_searchable_attributes(NEW_SEARCHABLE_ATTRIBUTES)
+    update = index.wait_for_pending_update(response['updateId'])
+    assert update['status'] == 'processed'
+    # Check the settings have been correctly updated
+    response = index.get_searchable_attributes()
+    assert len(response) == len(NEW_SEARCHABLE_ATTRIBUTES)
+    for attribute in NEW_SEARCHABLE_ATTRIBUTES:
+        assert attribute in response
+    # Check the reset of the settings
     response = index.reset_searchable_attributes()
     assert isinstance(response, object)
     assert 'updateId' in response

meilisearch/tests/settings/test_settings_stop_words_meilisearch.py

@@ -23,6 +23,16 @@ def test_update_stop_words(empty_index):
 def test_reset_stop_words(empty_index):
     """Tests call to reset stop words"""
     index = empty_index()
+    # Update the settings first
+    response = index.update_stop_words(NEW_STOP_WORDS)
+    update = index.wait_for_pending_update(response['updateId'])
+    assert update['status'] == 'processed'
+    # Check the settings have been correctly updated
+    response = index.get_stop_words()
+    assert isinstance(response, object)
+    for stop_word in NEW_STOP_WORDS:
+        assert stop_word in response
+    # Check the reset of the settings
     response = index.reset_stop_words()
     assert isinstance(response, object)
     assert 'updateId' in response

meilisearch/tests/settings/test_settings_synonyms_meilisearch.py

@@ -25,6 +25,16 @@ def test_update_synonyms(empty_index):
 def test_reset_synonyms(empty_index):
     """Tests resetting synonyms"""
     index = empty_index()
+    # Update the settings first
+    response = index.update_synonyms(NEW_SYNONYMS)
+    update = index.wait_for_pending_update(response['updateId'])
+    assert update['status'] == 'processed'
+    # Check the settings have been correctly updated
+    response = index.get_synonyms()
+    assert isinstance(response, object)
+    for synonym in NEW_SYNONYMS:
+        assert synonym in response
+    # Check the reset of the settings
     response = index.reset_synonyms()
     assert isinstance(response, object)
     assert 'updateId' in response