Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support domain for metadata sources #120

Open
mseaton opened this issue May 28, 2021 · 2 comments
Open

Support domain for metadata sources #120

mseaton opened this issue May 28, 2021 · 2 comments
Labels

Comments

@mseaton
Copy link
Collaborator

mseaton commented May 28, 2021

Currently, there is a domain for metadatatermmappings, which allow recording terms within a metadata source. However, there is no mechanism for creating that metadatasource that the terms refer to. This leads to errors upon startup and loading terms that depend on a given source, as there is no way to ensure that sources created in other modules are available.

Likely this requires adding a new entry to Domain.java, and new MetadataSourceCsvParser, MetadataSourceLineProcessor, and MetadataSourceLoader to the existing org.openmrs.module.api.mdm package, adding relevant unit tests, and updating the README to reflect this addition.

This is most immediately pertinent to anyone who wishes to use Initializer to add the emrapi mapping terms, as the EMR API module activator adds in the necessary source if it does not exist, but does not necessarily load before Initializer runs (as Initializer is not aware of it). The same would be true for any other metadata sources, but this is the primary use case that led to this ticket.

@mks-d
Copy link
Member

mks-d commented Jun 28, 2024

@mseaton is this still current or we can close this issue?

@mseaton
Copy link
Collaborator Author

mseaton commented Jun 28, 2024

This is still current AFAIK

@mks-d mks-d added the feature label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants