Remove false positives when scanning canonical header information

Author: foretspaisibles

src/inspector/codestyle-0005.lisp

@@ -46,7 +46,7 @@ license under which the file is released."
 			(:sequence
 			 #\Space
 			 (:greedy-repetition 0 nil :everything)
-			 (:alternation ,(project-name) "https" "Copyright" "This file is part of" "All rights reserved")	
+			 (:alternation "https" "Copyright" "This file is part of" "All rights reserved")	
 			 (:greedy-repetition 0 nil :everything)))
 		       #\Newline)))
 	       `(:sequence

testsuite/inspector/codestyle-0005.lisp

@@ -23,7 +23,7 @@
 	     ";; Copyright 2021"
 	     ";; All rights reserved"
 	     ""
-	     ";; End of file `testsuite.lsip'")))
+	     ";; End of file `testsuite.lisp'")))
 	(file-2
 	  (atelier::join-lines
 	   '("; testsuite.lisp -- The testsuite for Example"
@@ -34,9 +34,52 @@
 	     ";;;; Copyright © 2017–2022 A. U. Thor"
 	     ";;;; All rights reserved."
 	     ""
-	     ";; End of file `testsuite.lsip'")))
+	     ";; End of file `testsuite.lisp'")))
 	(atelier::*linter*
 	  (atelier::find-plain-linter :application/lisp)))
+    (assert-string= file-2
+		    (with-fixed-linter-environment
+			(atelier::hint-at-file-when-it-lacks-canonical-project-identification file-1)))))
+
+(define-testcase validate-codestyle-0005-hint-at-script-when-it-lacks-canonical-project-identification ()
+  (let ((file-1
+	  (atelier::join-lines
+	   '("#!/bin/sh"
+	     ""
+	     "# testsuite.sh — The testsuite for Example"
+	     ""
+	     "# Another Project (https://github.com/acme/another-project)"
+	     "# This file is part of Another Project."
+	     "#"
+	     "# Copyright © 2001 Author"
+	     "# All rights reserved."
+	     ""
+	     "# This file must be used under the terms of the MIT License."
+	     "# This source file is licensed as described in the file LICENSE, which"
+	     "# you should have received as part of this distribution. The terms"
+	     "# are also available at https://opensource.org/licenses/MIT"
+	     ""
+	     ": ${TOPLEVELDIR:=$(git rev-parse --show-toplevel)}")))
+	(file-2
+	  (atelier::join-lines
+	   '("#!/bin/sh"
+	     ""
+	     "# testsuite.sh — The testsuite for Example"
+	     ""
+	     "# Example (https://github.com/acme/example)"
+	     "# This file is part of Example."
+	     "#"
+	     "# Copyright © 2017–2022 A. U. Thor"
+	     "# All rights reserved."
+	     ""
+	     "# This file must be used under the terms of the MIT License."
+	     "# This source file is licensed as described in the file LICENSE, which"
+	     "# you should have received as part of this distribution. The terms"
+	     "# are also available at https://opensource.org/licenses/MIT"
+	     ""
+	     ": ${TOPLEVELDIR:=$(git rev-parse --show-toplevel)}")))
+	(atelier::*linter*
+	  (atelier::find-plain-linter :application/shellscript)))
     (assert-string= file-2
 		    (with-fixed-linter-environment
 		      (atelier::hint-at-file-when-it-lacks-canonical-project-identification file-1)))))

testsuite/lint.lisp

@@ -64,6 +64,7 @@
   (validate-codestyle-0003-hint-at-file-when-it-lacks-canonical-header-line)
   (validate-codestyle-0004-hint-at-file-when-it-lacks-canonical-footer-line)
   (validate-codestyle-0005-hint-at-file-when-it-lacks-canonical-project-identification)
+  (validate-codestyle-0005-hint-at-script-when-it-lacks-canonical-project-identification)
   (validate-codestyle-0006-hint-at-file-when-it-lacks-project-license-information))
 
 ;;;; End of file `lint.lisp'