Merge pull request #11 from membraneframework/fix-memory-leak

Fixed leaking unifex payload

Author: Qizot

README.md

@@ -22,9 +22,7 @@ end
 
 ## Usage
 
-Basically this library works similarly to [libnice] except that it doesn't support some features
-yet (e.g. TURN servers).
-
+Basically this library works similarly to [libnice].
 Example flow can look in the following way (this is not complete i.e. runnable example).
 
 Listed functions must be invoked on both peers.

c_src/ex_libnice/native.c

@@ -139,6 +139,7 @@ static void cb_recv(NiceAgent *_agent, guint stream_id, guint component_id,
   UnifexPayload *payload = unifex_payload_alloc(state->env, UNIFEX_PAYLOAD_BINARY, len);
   memcpy(payload->data, buf, len);
   send_ice_payload(state->env, *state->env->reply_to, 0, stream_id, component_id, payload);
+  unifex_payload_release(payload);
 }
 
 UNIFEX_TERM add_stream(UnifexEnv *env, UnifexState *state,
@@ -255,7 +256,9 @@ UNIFEX_TERM get_local_credentials(UnifexEnv *env, State *state, unsigned int str
   memcpy(credentials + lenufrag + 1, pwd, lenpwd + 1);
   g_free(ufrag);
   g_free(pwd);
-  return get_local_credentials_result_ok(env, credentials);
+  UNIFEX_TERM ret = get_local_credentials_result_ok(env, credentials); 
+  unifex_free(credentials);
+  return ret;
 }
 
 UNIFEX_TERM set_remote_credentials(UnifexEnv *env, State *state,

lib/ex_libnice.ex

@@ -521,6 +521,11 @@ defmodule ExLibnice do
     {:noreply, state}
   end
 
+  @impl true
+  def terminate(_reason, %State{cnode: cnode}) do
+    Unifex.CNode.stop(cnode)
+  end
+
   defp lookup_stun_servers(stun_servers) do
     Bunch.Enum.try_map(stun_servers, fn %{server_addr: addr, server_port: port} ->
       case lookup_addr(addr) do