Skip to content

Commit e6d2b05

Browse files
committed
Update tests
1 parent 2349270 commit e6d2b05

File tree

17 files changed

+49
-13
lines changed

17 files changed

+49
-13
lines changed
59.4 KB
Loading

maestro/images/expected/ios/bg_image_dynamic_svg_alert.png renamed to maestro/images/expected/ios/bg_image_dynamic_svg.png

File renamed without changes.
-8.7 KB
Loading

packages/pluggableWidgets/background-image-native/e2e/specs/maestro/BgImage_dynamic_image.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@ appId: "${APP_ID}"
88
text: "Background image"
99
- tapOn:
1010
text: "Dynamic image"
11-
- extendedWaitUntil:
12-
visible:
13-
id: "dynamicBgImage"
14-
timeout: 30000
15-
# - takeScreenshot:
16-
# path: "maestro/images/actual/${PLATFORM}/bg_image_dynamic_image"
11+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
12+
- extendedWaitUntil:
13+
visible: randText # Any random text that does not exist in the UI
14+
optional: true # This should be true so that the test won't fail
15+
timeout: 30000 # 15 seconds
16+
- takeScreenshot:
17+
path: "maestro/images/actual/${PLATFORM}/bg_image_dynamic_image"

packages/pluggableWidgets/background-image-native/e2e/specs/maestro/BgImage_dynamic_svg.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@ appId: "${APP_ID}"
88
text: "Background image"
99
- tapOn:
1010
text: "Dynamic SVG image"
11-
- extendedWaitUntil:
12-
visible: "Dynamic SVG image"
13-
timeout: 30000
14-
optional: true
15-
# - takeScreenshot:
16-
# path: "maestro/images/actual/${PLATFORM}/bg_image_dynamic_svg"
11+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
12+
- extendedWaitUntil:
13+
visible: randText # Any random text that does not exist in the UI
14+
optional: true # This should be true so that the test won't fail
15+
timeout: 15000 # 15 seconds
16+
- takeScreenshot:
17+
path: "maestro/images/actual/${PLATFORM}/bg_image_dynamic_svg"

packages/pluggableWidgets/background-image-native/e2e/specs/maestro/BgImage_layout_grid.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,10 @@ appId: "${APP_ID}"
99
- tapOn:
1010
text: "Layout grid"
1111
- assertVisible: "Layout grid"
12+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
13+
- extendedWaitUntil:
14+
visible: randText # Any random text that does not exist in the UI
15+
optional: true # This should be true so that the test won't fail
16+
timeout: 15000 # 15 seconds
1217
- takeScreenshot:
1318
path: "maestro/images/actual/${PLATFORM}/bg_image_layout_grid"

packages/pluggableWidgets/background-image-native/e2e/specs/maestro/BgImage_nested.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,10 @@ appId: "${APP_ID}"
99
- tapOn:
1010
text: "Nested"
1111
- assertVisible: "Nested"
12+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
13+
- extendedWaitUntil:
14+
visible: randText # Any random text that does not exist in the UI
15+
optional: true # This should be true so that the test won't fail
16+
timeout: 15000 # 15 seconds
1217
- takeScreenshot:
1318
path: "maestro/images/actual/${PLATFORM}/bg_image_nested"

packages/pluggableWidgets/background-image-native/e2e/specs/maestro/BgImage_static_images.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,10 @@ appId: "${APP_ID}"
1010
text: "Static images"
1111
- assertVisible:
1212
text: "Static images"
13+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
14+
- extendedWaitUntil:
15+
visible: randText # Any random text that does not exist in the UI
16+
optional: true # This should be true so that the test won't fail
17+
timeout: 10000 # 10 seconds
1318
- takeScreenshot:
1419
path: "maestro/images/actual/${PLATFORM}/bg_image_static_images"

packages/pluggableWidgets/image-native/e2e/specs/maestro/Image_dynamic.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@ appId: "${APP_ID}"
1212
- extendedWaitUntil:
1313
visible: randText # Any random text that does not exist in the UI
1414
optional: true # This should be true so that the test won't fail
15-
timeout: 15000 # 15 seconds
15+
timeout: 30000 # 30 seconds
1616
- takeScreenshot:
1717
path: "maestro/images/actual/${PLATFORM}/image_dynamic"

packages/pluggableWidgets/safe-area-view-native/e2e/specs/maestro/SafeAreaViewBottomBar.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,5 @@ appId: "${APP_ID}"
1313
\ - Safe area has an orange background color\r
1414
1515
\ - Bottom bar starts directly below safe area"
16+
- takeScreenshot:
17+
path: "maestro/images/actual/${PLATFORM}/safe_area_view_bottom_bar"

0 commit comments

Comments
 (0)