Skip to content

Commit c99ddf8

Browse files
committed
feat: introduce maker for popup/dropdowns in data widgets components
1 parent fedc3a1 commit c99ddf8

File tree

8 files changed

+14
-1
lines changed

8 files changed

+14
-1
lines changed

packages/pluggableWidgets/combobox-web/src/components/ComboboxMenuWrapper.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ export function ComboboxMenuWrapper(props: ComboboxMenuWrapperProps): ReactEleme
6161
}
6262
: style
6363
}
64+
data-overlay-content={isOpen || undefined}
6465
>
6566
{menuHeaderContent && (
6667
<div

packages/pluggableWidgets/datagrid-date-filter-web/src/components/DatePicker.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ export function DatePicker(props: DatePickerProps): ReactElement {
4343
</span>
4444
<ReactDatePicker
4545
{...staticProps}
46+
popperContainer={({ children }) => (props.expanded ? <div data-overlay-content>{children}</div> : null)}
4647
allowSameDay={false}
4748
ariaLabelledBy={`${props.id}-label`}
4849
autoFocus={false}

packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@ export function ColumnSelector(props: ColumnSelectorProps): ReactElement {
125125
id={`${props.id}-column-selectors`}
126126
className={`column-selectors`}
127127
data-focusindex={0}
128+
data-overlay-content
128129
role="menu"
129130
style={{ ...correctedFloatingStyles, maxHeight }}
130131
{...getFloatingProps()}

packages/pluggableWidgets/popup-menu-web/src/components/Menu.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ export const Menu = forwardRef((props: MenuProps, propRef: RefObject<HTMLDivElem
2626
ref={ref}
2727
style={{ ...floatingStyles, ...props.style }}
2828
{...getFloatingProps?.({ className: "popupmenu-menu" })}
29+
data-overlay-content
2930
>
3031
{menuOptions}
3132
</ul>

packages/pluggableWidgets/tooltip-web/src/components/Tooltip.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ export const Tooltip = (props: TooltipProps): ReactElement => {
4848
ref={refs?.setFloating}
4949
style={floatingStyles}
5050
{...getFloatingProps?.()}
51+
data-overlay-content
5152
>
5253
{renderMethod === "text" ? textMessage : htmlMessage}
5354
<div className={`widget-tooltip-arrow-${staticSide}`} ref={setArrowElement} style={arrowStyles} />

packages/pluggableWidgets/tooltip-web/src/components/__tests__/__snapshots__/Tooltip.spec.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ exports[`Tooltip render DOM structure 1`] = `
1919
<div
2020
class="widget-tooltip-content"
2121
data-floating-ui-focusable=""
22+
data-overlay-content="true"
2223
id=":r0:"
2324
role="tooltip"
2425
style="position: fixed; left: 0px; top: 0px; transform: translate(0px, 0px);"

packages/shared/widget-plugin-dropdown-filter/src/controls/base/OptionsWrapper.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,13 @@ export const OptionsWrapper = forwardRef((props: OptionsWrapperProps, ref: RefOb
3333
options
3434
} = props;
3535
return (
36-
<div className={cls.popover} hidden={!isOpen} ref={ref} style={style}>
36+
<div
37+
className={cls.popover}
38+
hidden={!isOpen}
39+
ref={ref}
40+
style={style}
41+
data-overlay-content={isOpen || undefined}
42+
>
3743
<div className={cls.menuSlot}>
3844
<ul {...getMenuProps({ className: cls.menu, "aria-label": label })} onScroll={onMenuScroll}>
3945
{isOpen &&

packages/shared/widget-plugin-filtering/src/controls/filter-selector/FilterSelector.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ export function FilterSelector(props: FilterSelectorProps): ReactElement {
4242
className={classNames("filter-selectors", { hidden: !open, visible: open })}
4343
{...listboxProps}
4444
style={floatingStyles}
45+
data-overlay-content={open || undefined}
4546
>
4647
{open &&
4748
options.map((item, index) => (

0 commit comments

Comments
 (0)