Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes to nosdk8266 #14

Open
cnlohr opened this issue Mar 23, 2017 · 2 comments
Open

Backport changes to nosdk8266 #14

cnlohr opened this issue Mar 23, 2017 · 2 comments

Comments

@cnlohr
Copy link

cnlohr commented Mar 23, 2017

Considering you may be the first project that dinked with it significantly, what changes did you need to make to nosdk8266? What changes would you recommend? Would you mind making a pull request?

@mengstr
Copy link
Owner

mengstr commented Mar 24, 2017

Sure thing, will do. But in general it was rather straightforward to use as is, but when I added conditional compilation for an option go back to plain nonos to get wifi/telnet I got a lot of clashes in the declarations of the .h-files which required me to add more #ifdefs than I really wanted and also made me add some API declarations directly in the C-files.

I'll clean up all of that a bit and see if I can get some better order there.

@cnlohr
Copy link
Author

cnlohr commented Mar 24, 2017

Please consider getting it cleaned up a little and contributed back :-D I would love some more integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants