Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when vlfeat not found #15

Open
AbdealiLoKo opened this issue May 23, 2016 · 4 comments
Open

Better error message when vlfeat not found #15

AbdealiLoKo opened this issue May 23, 2016 · 4 comments

Comments

@AbdealiLoKo
Copy link

Currently if I try to install cyvlfeat without vlfeat installed, I get:

cyvlfeat/sift/cysift.c:280:21: fatal error: vl/host.h: No such file or directory
  compilation terminated.

This makes sense, because vl/host.h cannot be found, as vlfeat is not installed.
But, it would be nicer to mention something like "Could not find vlfeat http://www.vlfeat.org/. Please install it and then install cyvlfeat"

NOTE: This is again, when I use this with pip. The readme says vlfeat is auto installed in conda (I don't normally use conda so have not tried with conda)

You can see the whole error message at https://s3.amazonaws.com/archive.travis-ci.org/jobs/132164694/log.txt

@patricksnape
Copy link
Contributor

patricksnape commented May 23, 2016

Yes this is currently expected behaviour as pip installing is not recommended not fully supported at the moment as you must satisfy the vlfeat dependency yourself. This is essentially the same problem as #14. This can be fixed but requires some work on the setup.py as detailed in #14.

@AbdealiLoKo
Copy link
Author

What I was thinking when creating this issue was that a better error
message should be given. I understand that vlfeat cannot be installed with
pypi.
But something like saying "Hey there, please install vlfeat and try again"
instead of the error message it gives right now

On Mon, May 23, 2016 at 7:31 PM, Patrick Snape notifications@github.com
wrote:

Yes this is currently expected behaviour as pip installing is not
recommended not fully supported at the moment as you must satisfy the
vlfeat dependency yourself. This is essentially the same problem as #14
#14.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#15 (comment)

@AbdealiLoKo
Copy link
Author

I thought they were separate issues (As this is simply giving a better
error message) and this would be simpler. But if this gets solved by #14
#14, then please do close this :)

On Mon, May 23, 2016 at 7:39 PM, Abdeali Kothari abdealikothari@gmail.com
wrote:

What I was thinking when creating this issue was that a better error
message should be given. I understand that vlfeat cannot be installed with
pypi.
But something like saying "Hey there, please install vlfeat and try again"
instead of the error message it gives right now

On Mon, May 23, 2016 at 7:31 PM, Patrick Snape notifications@github.com
wrote:

Yes this is currently expected behaviour as pip installing is not
recommended not fully supported at the moment as you must satisfy the
vlfeat dependency yourself. This is essentially the same problem as #14
#14.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#15 (comment)

@patricksnape
Copy link
Contributor

We could sort this separately but it would certainly be part of #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants