-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New main branch SDK doesn't use the intended user agent string format #21
Labels
bug
Something isn't working
Comments
Note that the community version of the go SDK already uses and should continue to use |
fmunozmiranda
added a commit
that referenced
this issue
Mar 12, 2024
UserAgent is now custom. |
fmunozmiranda
added a commit
that referenced
this issue
Mar 14, 2024
- New main branch SDK doesn't use the intended user agent string format #21 - Incorrect links to documentation in code #23 [Removed] - API Rate limiting is not handled in client #20 - Refactor api client to adhere to rate limits #25 - `AccessPolicyNumber` was absent in response structs of `ResponseSwitchGetNetworkSwitchAccessPolicy` and `ResponseItemSwitchGetNetworkSwitchAccessPolicies`.
This doesn't sound like the right solution, based on my report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Describe the bug
In https://github.com/meraki/dashboard-api-go/blob/main/sdk/api_client.go, line 85 reads
c.SetUserAgent("MerakiGolang/2.0.4 Cisco")
This UA string has a couple of issues.
Expected behavior
go-meraki/{equivalent Meraki OAS revision number}
, e.g.go-meraki/1.47.0
ApplicationName VendorName
(similar to the python SDK, see line 86 here and line 75 here)ApplicationName VendorName
) so that the full UA string submitted ends up following this format:go-meraki/1.47.0 ApplicationName VendorName
where1.47.0
is the dashboard API revision for which the library is builtScreenshots
N/A
Environment (please complete the following information):
N/A
Thanks in advance for helping with this.
The text was updated successfully, but these errors were encountered: