test: fix flaky tests #54

marco-ippolito · 2023-01-25T16:08:41Z

resolves: #53
I'll try to fix flakiness of some tests.
On this one I think its the timers

mercurius-gateway/test/retry-failed-services.js

Lines 385 to 448 in eddd8be

    
           test('gateway - should log error if retry throws', async t => { 
        
             t.plan(1) 
        
             const service1 = await createTestService( 
        
               0, 
        
               userService.schema, 
        
               userService.resolvers 
        
             ) 
        
             let service2 = null 
        
             t.context.clock.setTimeout(async () => { 
        
               service2 = await createTestService( 
        
                 5114, 
        
                 postService.schema, 
        
                 postService.resolvers 
        
               ) 
        
             }, 2000) 
        
             const gateway = Fastify() 
        
             let errCount = 0 
        
             gateway.log.error = error => { 
        
               if (error.message.includes('kaboom') && errCount === 0) { 
        
                 errCount++ 
        
                 t.pass() 
        
               } 
        
             } 
        
             t.teardown(async () => { 
        
               await gateway.close() 
        
               await service1.close() 
        
               await service2.close() 
        
             }) 
        
             await gateway.register(plugin, { 
        
               gateway: { 
        
                 services: [ 
        
                   { 
        
                     name: 'user', 
        
                     url: `http://localhost:${service1.server.address().port}/graphql`, 
        
                     mandatory: false 
        
                   }, 
        
                   { 
        
                     name: 'post', 
        
                     url: 'http://localhost:5114/graphql', 
        
                     mandatory: true 
        
                   } 
        
                 ], 
        
                 retryServicesCount: 1, 
        
                 retryServicesInterval: 3000 
        
               }, 
        
               jit: 1 
        
             }) 
        
             gateway.graphqlGateway.addHook('onGatewayReplaceSchema', async () => { 
        
               throw new Error('kaboom') 
        
             }) 
        
             await gateway.ready() 
        
             for (let i = 0; i < 200; i++) { 
        
               await t.context.clock.tickAsync(50) 
        
             } 
        
           })

marco-ippolito · 2023-01-27T09:34:47Z

it seems starting service2 a bit earlier and removing the error count, make the test more stable, I dont think it these changes make the test less meaningful wdyt @mcollina

mcollina

lgtm

marco-ippolito added 6 commits January 25, 2023 17:06

test: try to reduce timeout

6394f05

test: try reduce setTimeout

1e8f036

test: increase retryServicesInterval

985d6d5

test: increase attempts

278942d

test: ignore error count

a37056c

test: dummy commit

9a8ac16

marco-ippolito marked this pull request as ready for review January 27, 2023 09:34

marco-ippolito changed the title ~~[WIP] fix flaky tests~~ test: fix flaky tests Jan 27, 2023

test: dummy commit

1375a2c

mcollina approved these changes Jan 27, 2023

View reviewed changes

mcollina merged commit 49afc34 into mercurius-js:main Jan 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: fix flaky tests #54

test: fix flaky tests #54

marco-ippolito commented Jan 25, 2023 •

edited

Loading

marco-ippolito commented Jan 27, 2023 •

edited

Loading

mcollina left a comment


	test('gateway - should log error if retry throws', async t => {
	t.plan(1)
	const service1 = await createTestService(
	0,
	userService.schema,
	userService.resolvers
	)

	let service2 = null
	t.context.clock.setTimeout(async () => {
	service2 = await createTestService(
	5114,
	postService.schema,
	postService.resolvers
	)
	}, 2000)

	const gateway = Fastify()

	let errCount = 0
	gateway.log.error = error => {
	if (error.message.includes('kaboom') && errCount === 0) {
	errCount++
	t.pass()
	}
	}

	t.teardown(async () => {
	await gateway.close()
	await service1.close()
	await service2.close()
	})

	await gateway.register(plugin, {
	gateway: {
	services: [
	{
	name: 'user',
	url: `http://localhost:${service1.server.address().port}/graphql`,
	mandatory: false
	},
	{
	name: 'post',
	url: 'http://localhost:5114/graphql',
	mandatory: true
	}
	],
	retryServicesCount: 1,
	retryServicesInterval: 3000
	},
	jit: 1
	})

	gateway.graphqlGateway.addHook('onGatewayReplaceSchema', async () => {
	throw new Error('kaboom')
	})

	await gateway.ready()

	for (let i = 0; i < 200; i++) {
	await t.context.clock.tickAsync(50)
	}
	})

test: fix flaky tests #54

test: fix flaky tests #54

Conversation

marco-ippolito commented Jan 25, 2023 • edited Loading

marco-ippolito commented Jan 27, 2023 • edited Loading

mcollina left a comment

Choose a reason for hiding this comment

marco-ippolito commented Jan 25, 2023 •

edited

Loading

marco-ippolito commented Jan 27, 2023 •

edited

Loading