Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic entries can cause data loss #58

Open
bergie opened this issue Sep 18, 2024 · 2 comments
Open

Automatic entries can cause data loss #58

bergie opened this issue Sep 18, 2024 · 2 comments

Comments

@bergie
Copy link
Member

bergie commented Sep 18, 2024

Very rare occurrence, but I've seen this now happen twice (in some 7k miles logged with logbook) where an automatic entry made into a day can somehow lose all previous entries from the day.

Here's an example of this happening (via a sail change log entry): meri-imperiumi/log@af17576

@bergie
Copy link
Member Author

bergie commented Sep 18, 2024

It is almost certainly caused in https://github.com/meri-imperiumi/signalk-logbook/blob/main/plugin/Log.js#L125

return this.getDate(date).catch(() => []);

As to why we get an error when reading the stored entry, no idea.

@bergie
Copy link
Member Author

bergie commented Oct 29, 2024

7b9fa7b might be the fix. Sometimes navigation.position seems to contain invalid additonal keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant