-
-
Notifications
You must be signed in to change notification settings - Fork 351
Port “Compass view” bottom sheet from Meshtastic-Apple PR #1504 #3896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
Why lines not a compass rose? And why are there 3 lines for a single bearing? |
Personal preference and re-using some old code I had from another project. Red is fixed line on the N marker; the thin under it is a heading line. Align the black lines and your walking directly to the node (accessibility feature mostly from the old project). Orignal code and design I was playing with had support for multiple nodes on the rose (and that might a future PR - with a rose accessible from somewhere else). Totem Compass style - show where you stared nodes are both distance and direction from you. For the moment; happy to drop the heading and red lines if folks prefer. |
|
Should there perhaps be a message displayed when the target node has a high degree of precision bits? So we don't send the users on a wild goosechase |
Let me see how hard it would be to tell the user the degree of error on the screen.. if its communicated somewhere.. |
|
@DaneEvans @mdecourcy - ok simplified the rose and did implement an accuracy cone-
I need to test this on some more physical devices though- only tested this in the emulator right now- but would love feedback.
|
|
Converting to draft pending physical device testing of the error cone. |
|
@jakevis I made a pr into your fork repo to improve the view of the compass. |
Improved the compass
Looks amazing! Thank you! |
|
The only thing I have not fully tested is the uncertainty feature, also I did not figure out how to localize distance since right now it only shows km |
|
I have a todo item tomorrow to test this on a couple physical devices now I'm back from the weekend. I want to check the uncertainty cone some more- it's a tad hard to do in the emulator. I have ran codex-max over it before I pushed to my branch; but yes - I would certainly say copilot should triple check 😀 - I can ask codex to take a pass at the localization as well. |




This ports the “Compass view” from Meshtastic-Apple PR pull/1504 (thanks @RCGV1) to Android. It keeps the phone’s location as origin and guides you to the selected node via a modal bottom sheet on Node Detail → Position → “Open Compass.”
What changed
Why
Per the iOS PR: adds a compass view to quickly navigate to a node—useful off-grid when locating a friend, dog, or tracker.
Testing