Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to reflect changes to <Recipient> response validator that made acs-url required in #33 #40

Open
camsaul opened this issue Sep 29, 2020 · 4 comments

Comments

@camsaul
Copy link
Member

camsaul commented Sep 29, 2020

#33 changed the way the <Recipient> response validator worked so it throws an Exception if acs-url is not set

https://github.com/metabase/saml20-clj/pull/33/files#diff-ec108a28be532b68fc3d082fae04d68aR103-R114

We need to update the README to reflect this, since it suggests otherwise.

@camsaul camsaul changed the title Reconsider changes to <Recipient> response validator that made acs-url required in #33 Update README to reflect changes to <Recipient> response validator that made acs-url required in #33 Sep 29, 2020
@camsaul
Copy link
Member Author

camsaul commented Sep 29, 2020

Ping @dbrrr

@dbrrr
Copy link

dbrrr commented Sep 30, 2020

#42

I think the acs-url is not technically required -- it will just throw an error if the <Recipient> is present and there is no acs-url to verify against. But I changed the README to say "highly recommended :)

@dbrrr
Copy link

dbrrr commented Sep 30, 2020

Ah nevermind, I reverted that change to show "required" now

Worth noting that :acs-url is passed in the request -- we could, in theory, maintain it in the StateManager for use in checking against the response.

@dbrrr
Copy link

dbrrr commented Oct 16, 2020

@camsaul I think this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants