-
Notifications
You must be signed in to change notification settings - Fork 5
Attempt to actually cache something #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
vercel.json
Outdated
| { | ||
| "key": "CDN-Cache-Control", | ||
| "value": "public, max-age=2592000" | ||
| "value": "max-age=0, s-maxage=2592000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the recommended header instead.
|
✅ Preview Deployment Ready! |
|
✅ Preview Deployment Ready! |
|
The below deployment is the one with |
This comment was marked as outdated.
This comment was marked as outdated.
6813352 to
69a0c2e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
✅ Preview Deployment Ready! |
|
Note: using vercel function. I couldn't get cache to work at all. |
Try to fix https://linear.app/metabase/issue/EMB-986/investigate-vercel-cdn-not-caching-shoppy-sdk-bundle-as-much-as
Log URL: https://vercel.com/embedding-c312e713/shoppy/logs?refreshedAt=1762782025584&searchQuery=embedding-sdk.js&selectedLogId=4bnr8-1762866772501-9f43dac8f735&domains=shoppy-g3gotz591-embedding-c312e713.vercel.app&timeline=maximum
This uses the host from this deployment, to see how long caches are persisted now.