From 3906b7d1c84138c3b6d574d6b515c3db3d5f2a00 Mon Sep 17 00:00:00 2001 From: Robert Kaye Date: Fri, 14 May 2021 17:37:30 +0200 Subject: [PATCH] Separate fields with a , (#69) * Separate fiels with a , * Fix metrics test * Fix test Co-authored-by: Kartik Ohri --- brainzutils/metrics.py | 2 +- brainzutils/test/test_metrics.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/brainzutils/metrics.py b/brainzutils/metrics.py index bf6151e..ca7d9da 100644 --- a/brainzutils/metrics.py +++ b/brainzutils/metrics.py @@ -66,7 +66,7 @@ def set(metric_name: str, tags: Dict[str, str] = None, timestamp: int = None, ** else: fields_list.append("%s=%s" % (k, str(v))) - fields = " ".join(fields_list) + fields = ",".join(fields_list) if timestamp is None: timestamp = time_ns() diff --git a/brainzutils/test/test_metrics.py b/brainzutils/test/test_metrics.py index c96e2c8..8b898f2 100644 --- a/brainzutils/test/test_metrics.py +++ b/brainzutils/test/test_metrics.py @@ -19,4 +19,4 @@ def test_set(self, rpush): os.environ["PRIVATE_IP"] = "127.0.0.1" metrics.set("my_metric", timestamp=1619629462352960742, test_i=2, test_fl=.3, test_t=True, test_f=False, test_s="gobble") rpush.assert_called_with(metrics.REDIS_METRICS_KEY, - 'my_metric,dc=hetzner,server=127.0.0.1,project=listenbrainz.org test_i=2i test_fl=0.3 test_t=t test_f=f test_s="gobble" 1619629462352960742') + 'my_metric,dc=hetzner,server=127.0.0.1,project=listenbrainz.org test_i=2i,test_fl=0.3,test_t=t,test_f=f,test_s="gobble" 1619629462352960742')