Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out meaning of SQL_ATTR_MAX_ROWS code #10

Open
hostilefork opened this issue Feb 20, 2020 · 0 comments
Open

Figure out meaning of SQL_ATTR_MAX_ROWS code #10

hostilefork opened this issue Feb 20, 2020 · 0 comments

Comments

@hostilefork
Copy link
Member

There was code in Christian Ensel's original ODBC extension which would set the number of rows, but was commented out saying it was "in the wrong place" (?).

It was preserved as:

// SQLULEN max_rows = 0;
// rc = SQLSetStmtAttr(hstmt, SQL_ATTR_MAX_ROWS, &max_rows, SQL_IS_POINTER);
// if (not SQL_SUCCEEDED(rc))
//     rebJumps ("fail", Error_ODBC_Stmt(hstmt));

But turned into an issue here, as being preferable to keeping commented out code in the file. So someone can take interest in what this is for and how it might be used correctly.

@hostilefork hostilefork changed the title Figure out meaning of Figure out meaning of SQL_ATTR_MAX_ROWS code Feb 20, 2020
@hostilefork hostilefork transferred this issue from metaeducation/ren-c Feb 20, 2020
hostilefork added a commit to metaeducation/ren-c that referenced this issue Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant