Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select mirrord.json as default config choice #130

Open
emanuelef opened this issue May 29, 2024 · 3 comments
Open

Select mirrord.json as default config choice #130

emanuelef opened this issue May 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@emanuelef
Copy link

emanuelef commented May 29, 2024

Now it there are multiple files in .mirrord folder named *mirrord.json it's not clear which one will be used.

private static async getDefaultConfig(folder: vscode.WorkspaceFolder): Promise<vscode.Uri | undefined> {

In my case I have multiple files in that folder one named __mirrord.json, that was being used while I was expecting mirrord.json to be used.
I guess one option is to choose mirrord.json file over others containing mirrord, or document this somewhere.

@emanuelef emanuelef added the enhancement New feature or request label May 29, 2024
@aviramha
Copy link
Member

I think we should restrict the regex to mirrord.{json/yaml/toml} for default config

@emanuelef
Copy link
Author

I guess the only risk there is for people who don't have mirrord.{json/yaml/toml} but something like *mirrord, so for them it will stop working when upgrading.

@emanuelef emanuelef changed the title Select mirror.json as default config choice Select mirrord.json as default config choice May 29, 2024
@Razz4780
Copy link
Contributor

The plugin sorts default config candidates using String.localeCompare and always picks the first one from the list. We should document it somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants