From 03f9b517ba80eb90b94abb487167e4960c3a0ae8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20Sch=C3=BCth?= Date: Thu, 2 Feb 2023 08:51:08 +0100 Subject: [PATCH] Apply fix for gRPC tests as well --- .../io/metaloom/qdrant/client/AbstractContainerTest.java | 8 ++++++++ .../client/grpc/method/SnapshotGRPCClientTest.java | 2 ++ .../qdrant/client/http/AbstractHTTPClientTest.java | 9 --------- .../client/http/method/SnapshotHttpClientTest.java | 1 + 4 files changed, 11 insertions(+), 9 deletions(-) diff --git a/common/src/test/java/io/metaloom/qdrant/client/AbstractContainerTest.java b/common/src/test/java/io/metaloom/qdrant/client/AbstractContainerTest.java index ac45a89..5fd072a 100644 --- a/common/src/test/java/io/metaloom/qdrant/client/AbstractContainerTest.java +++ b/common/src/test/java/io/metaloom/qdrant/client/AbstractContainerTest.java @@ -9,4 +9,12 @@ public abstract class AbstractContainerTest { @Rule public QDrantContainer qdrant = new QDrantContainer(); + protected void sleep(int i) { + try { + Thread.sleep(i); + } catch (InterruptedException e) { + e.printStackTrace(); + } + } + } diff --git a/grpc/src/test/java/io/metaloom/qdrant/client/grpc/method/SnapshotGRPCClientTest.java b/grpc/src/test/java/io/metaloom/qdrant/client/grpc/method/SnapshotGRPCClientTest.java index 09ad77a..f5e0874 100644 --- a/grpc/src/test/java/io/metaloom/qdrant/client/grpc/method/SnapshotGRPCClientTest.java +++ b/grpc/src/test/java/io/metaloom/qdrant/client/grpc/method/SnapshotGRPCClientTest.java @@ -23,6 +23,8 @@ public void testCreateCollectionSnapshot() throws Exception { createCollection(TEST_COLLECTION_NAME); client.createSnapshot(TEST_COLLECTION_NAME).sync(); assertEquals(1, client.listSnapshots(TEST_COLLECTION_NAME).sync().getSnapshotDescriptionsCount()); + // The snapshot filename is named via seconds. We need to pass some time to allow for creation of another file + sleep(2000); client.createSnapshot(TEST_COLLECTION_NAME).sync(); assertEquals(2, client.listSnapshots(TEST_COLLECTION_NAME).sync().getSnapshotDescriptionsCount()); } diff --git a/http/src/test/java/io/metaloom/qdrant/client/http/AbstractHTTPClientTest.java b/http/src/test/java/io/metaloom/qdrant/client/http/AbstractHTTPClientTest.java index c6975b5..8cc022e 100644 --- a/http/src/test/java/io/metaloom/qdrant/client/http/AbstractHTTPClientTest.java +++ b/http/src/test/java/io/metaloom/qdrant/client/http/AbstractHTTPClientTest.java @@ -76,15 +76,6 @@ protected T invoke(QDrantClientRequest request) thro } } - protected void sleep(int i) { - try { - Thread.sleep(i); - } catch (InterruptedException e) { - e.printStackTrace(); - } - - } - protected void createTestCollection() throws HttpErrorException { CollectionCreateRequest request = new CollectionCreateRequest(); request.setVectors(VectorParams.of(4, EUCLID)); diff --git a/http/src/test/java/io/metaloom/qdrant/client/http/method/SnapshotHttpClientTest.java b/http/src/test/java/io/metaloom/qdrant/client/http/method/SnapshotHttpClientTest.java index fbc617d..804a219 100644 --- a/http/src/test/java/io/metaloom/qdrant/client/http/method/SnapshotHttpClientTest.java +++ b/http/src/test/java/io/metaloom/qdrant/client/http/method/SnapshotHttpClientTest.java @@ -108,6 +108,7 @@ public void testCreateStorageSnapshot() throws Exception { public void testListStorageSnapshot() throws Exception { invoke(client.createStorageSnapshot()); createCollection(TEST_COLLECTION_NAME); + // The snapshot filename is named via seconds. We need to pass some time to allow for creation of another file sleep(2000); invoke(client.createStorageSnapshot()); List snapshots = invoke(client.listStorageSnapshots()).getResult();