Skip to content

Commit e64387f

Browse files
committed
Drop old collector.prototyp implementation
It's because old implementation does not satisfy latest tests and we have modern implementation on prototypes. Old one is quick but this speed is a result of less functionality, not the different approach.
1 parent 85509e9 commit e64387f

File tree

4 files changed

+2
-157
lines changed

4 files changed

+2
-157
lines changed

lib/collector.prototype.js

Lines changed: 0 additions & 134 deletions
This file was deleted.

tests/load/collect.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const COUNT = 1000000;
55
const benchmark = require('./benchmark.js');
66
const metasync = require('../../lib/collector.js');
77

8-
const CollectPrototype = done => {
8+
const Collect = done => {
99
const dc = metasync.collect(6);
1010
dc.done(done);
1111
let i = 0;
@@ -17,4 +17,4 @@ const CollectPrototype = done => {
1717
setImmediate(() => dc.pick('6th', 'key' + ++i * 2));
1818
};
1919

20-
benchmark.do(COUNT, [CollectPrototype]);
20+
benchmark.do(COUNT, [Collect]);

tests/load/collect.prototype.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

tests/load/run.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,4 @@ echo
1515
echo Collector: 1mnl
1616
node tests/load/collect.js
1717
node tests/load/collect.class.js
18-
node tests/load/collect.prototype.js
1918
node tests/load/collect.functor.js

0 commit comments

Comments
 (0)