Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tool translates only one .strings file from the target dir and skips the rest of files #25

Open
vitalii-tym opened this issue Sep 17, 2018 · 1 comment
Open

The tool translates only one .strings file from the target dir and skips the rest of files #25

vitalii-tym opened this issue Sep 17, 2018 · 1 comment

Comments

@vitalii-tym
Copy link
Contributor

tried to debug it: it seems to be correctly making a list of files and starts to loop through them, but the break statement on line 342 goes out of the loop after the very first file added to base_dict.

If I remove the break sentence - it seems to be taking all the files as expected. But I can't verify it works correctly yet because of one other bug. Will try to make a PR as soon as I'm sure it works.
@metasmile
Copy link
Owner

👍@vitalii-tym
Previously I did create 'develop-autopath' branch related with your comment. But it has been paused.

vitalii-tym added a commit to vitalii-tym/strsync that referenced this issue Sep 19, 2018
@vitalii-tym
fixes bugs metasmile#25 and metasmile#24
1928eb4
metasmile added a commit that referenced this issue Nov 28, 2018
@metasmile
Merge pull request #27 from vitalii-tym/master
bd1a37a 
Fix for bugs #25 and #24
metasmile pushed a commit that referenced this issue Nov 28, 2018
@vitalii-tym @metasmile
fixes bugs #25 and #24
cd497d5
metasmile added a commit that referenced this issue Nov 28, 2018
@metasmile
fixes bugs #25 and #24
4a25ba4
metasmile pushed a commit that referenced this issue Nov 28, 2018
@vitalii-tym @metasmile
[FORCE MERGE TO DISPLAY CONTRIBUTOR's EMAIL] fixes bugs #25 and #24
a0b5502
metasmile pushed a commit that referenced this issue Dec 20, 2020
@vitalii-tym
fixes bugs #25 and #24
ad89e2c
metasmile added a commit that referenced this issue Dec 20, 2020
@metasmile
Merge pull request #27 from vitalii-tym/master
aaffe7b 
Fix for bugs #25 and #24
metasmile pushed a commit that referenced this issue Dec 20, 2020
@vitalii-tym @metasmile
fixes bugs #25 and #24
4a04175
metasmile added a commit that referenced this issue Dec 20, 2020
@metasmile
fixes bugs #25 and #24
0bc1784
metasmile pushed a commit that referenced this issue Dec 20, 2020
@vitalii-tym @metasmile
[FORCE MERGE TO DISPLAY CONTRIBUTOR's EMAIL] fixes bugs #25 and #24
83ca2d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metasmile @vitalii-tym