Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Cordova boilerplate does not play well with external scripts #148

Open
hwillson opened this issue Jul 12, 2017 · 6 comments
Open

Cordova boilerplate does not play well with external scripts #148

hwillson opened this issue Jul 12, 2017 · 6 comments

Comments

@hwillson
Copy link
Contributor

hwillson commented Jul 12, 2017

Migrated over from meteor/meteor#8876.
(originally reported by @ramijarrar)


The cordova template in the boilerplate-generator package currently loads any user-specified <head> after application JS code. This creates an incompatibility with external scripts that are expected on startup e.g for Stripe, Twilio, etc.

Is there a reason why we cannot load them first, or even move the application JS to <body> (which has already been done for the browser template)?

@ramijarrar
Copy link

@hwilson Thanks for migrating this, can you use a code-block for "user specified <head>" and "application JS to <body>" so they show up?

@hwillson
Copy link
Contributor Author

Sorry about that @ramijarrar - copy pasted in a hurry - thanks for pointing that out!

@rgnevashev
Copy link

Is there a reason why we cannot load js staff in the body, not in the head?

@abernix
Copy link
Contributor

abernix commented Aug 28, 2017

@ramijarrar @rgnevashev Not that I'm aware of. It may have just been that only the web.browser version of Boilerplate was changed to use that method. If you could test and report back with your findings, that would be very much appreciated! (This should be as easy as forking the boilerplate-generator package into your own local packages directory.)

@rgnevashev
Copy link

@abernix I've done forked pkg to local app packages but app is generating random template (first start generation is core meteor and after modify code it generates from my local pkg).. I try redesign the cordova template(put all js staff to body)... jquense/react-big-calendar#418 there is a reason why I need put all js staff to body.. react big calendar doesnt work and they dont try fix it.. they said "you need put all js staff to body" and closed issue..

@robinknox
Copy link

I also just had this problem with running a Meteor android app containing react-big-calendar. The dom-helpers dependency package which is causing the error currently has this PR open react-bootstrap/dom-helpers#29. This is currently blocking me from building my app for Android.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants