Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert reliability calibration tests pytest #1677

Open
lucyleeow opened this issue Feb 22, 2022 · 1 comment
Open

Convert reliability calibration tests pytest #1677

lucyleeow opened this issue Feb 22, 2022 · 1 comment
Assignees

Comments

@lucyleeow
Copy link
Contributor

lucyleeow commented Feb 22, 2022

Advantages of using pytest

  • prevents code duplication, e.g., with use of parametrize. This is especially useful to test enhancements (grid and site, point by point and aggregate)
  • fixtures allow standardisation across test scripts of sample input cubes and enables set up code to be in one place, separate from test code

This work has already started here: lucyleeow#1
This issue relates to conversion of the remaining reliability calibration tests to pytest.
Note there has already been some discussion via other channels about this.

cc @tjtg

@tjtg
Copy link
Contributor

tjtg commented Apr 7, 2022

This has been mostly addressed in #1667 and #1687 - these two PRs cover AggregateReliabilityCalibrationTables, ConstructReliabilityCalibrationTables and ManipulateReliabilityTable.

ApplyReliabilityCalibration is still remaining with UnitTest style tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants