You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #1702, we currently pin 'black' to 19.10b0 for both environment_a.yml and environment_b.yml. This gives rise to problems without pinning of its dependency 'click' (more information here: psf/black#2964).
For recent versions of black, this dependency issue with click has been resolved (>=22.3.0).
The question is then whether our pinning of black to 19.10b0 for environment_a.yml and environment_b.yml are strictly necessary?
Can we update this pinning to >=22.3.0
This does give rise to issues presented by black though I haven't looked at those changes in detail.
The text was updated successfully, but these errors were encountered:
@cpelley I don't think we pin for any reason other than leaving it floating means it can change underneath us. The github actions environment that is built can then differ from the local environment and we get test failures on PRs. Updating this would be fine by me, as long as the PR captured all of the changes required to conform to the newer version. It would also be worth ensuring it plays nicely with whatever version of isort we end up with as the two can ping-pong back and forth with particular combinations of versions.
As discussed in #1702, we currently pin 'black' to
19.10b0
for bothenvironment_a.yml
andenvironment_b.yml
. This gives rise to problems without pinning of its dependency 'click' (more information here: psf/black#2964).For recent versions of
black
, this dependency issue withclick
has been resolved (>=22.3.0).The question is then whether our pinning of black to
19.10b0
forenvironment_a.yml
andenvironment_b.yml
are strictly necessary?Can we update this pinning to >=22.3.0
This does give rise to issues presented by black though I haven't looked at those changes in detail.
The text was updated successfully, but these errors were encountered: