Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between find_percentile_coordinate and find_threshold_coordinate functions #1723

Open
tjtg opened this issue May 24, 2022 · 0 comments

Comments

@tjtg
Copy link
Contributor

tjtg commented May 24, 2022

During review in #1719, it was identified that the find_percentile_coordinate and find_threshold_coordinate functions in improver/metadata/probabilistic.py work differently to each other. In particular, find_percentile_coordinate contains additional logic to handle more than one percentile coordinate.
There are also simple is_percentile and is_threshold functions which use the find coordinate functions to identify the kind of probabilistic data being processed.

From some repository history digging, it looks like the two functions were implemented at different times and in different locations, then refactored to live in the same file as each other. Related PRs and issues: #974, #838, #833 and #314.

Acceptance criteria:
Option 1: updated code, either consistent between the two functions or removing duplication between the functions
Option 2: updated documentation explaining why the differences exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant