Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbhood_land_and_sea handling of missing data #1931

Open
thbom001 opened this issue Aug 23, 2023 · 0 comments
Open

nbhood_land_and_sea handling of missing data #1931

thbom001 opened this issue Aug 23, 2023 · 0 comments
Labels

Comments

@thbom001
Copy link
Contributor

There appears to be an inconsistency in the way the nbhood_land_and_sea plugin handles missing values in the incoming data cubes. Basically, missing values in the incoming data (for example a whole field of missing values when the model data did not get created for some reason) get treated as "0" values in the nbhood calculations. This appears to be inconsistent with the way other parts of the IMPROVER code handle missing values - the missing values get propagated through as missing values rather than being changed to something else.

I believe I have identified and fixed the code which causes this issue, and will create a PR and update this issue after I've done some further testing of the potential fix.

Acceptance criteria:

  • Missing data gets propagated through nbhood_land_and_sea processing and remains as missing in the output.
@thbom001 thbom001 added Type:Bug good first review This pull request is simpler to review MO review required PRs opened by non-Met Office developers that require a Met Office review labels Aug 23, 2023
@thbom001 thbom001 self-assigned this Aug 23, 2023
@dmentipl dmentipl removed good first review This pull request is simpler to review MO review required PRs opened by non-Met Office developers that require a Met Office review labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants