look inside :ref when searching for default for :map child #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a default value gets produced up via the normal transformer pipeline, the -transform method of -ref-schema will delegate to the child schema. However, when we're building up the default values for a :map in add-defaults, we're not using the transformer pipeline, but calling get-default manually. Thus, we need to manually deref. fixes #1145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a default value gets produced up via the normal transformer
pipeline, the -transform method of -ref-schema will delegate to the
child schema. However, when we're building up the default values for a
:map in add-defaults, we're not using the transformer pipeline, but
calling get-default manually. Thus, we need to manually deref.
fixes #1145