Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating fread call to not return integer64 #722

Open
kylebaron opened this issue Oct 1, 2024 · 2 comments
Open

Consider updating fread call to not return integer64 #722

kylebaron opened this issue Oct 1, 2024 · 2 comments

Comments

@kylebaron
Copy link
Contributor

readr doesn't do it and I think most of the time, I'd rather have double than integer64.

https://github.com/metrumresearchgroup/bbr/blob/main/R/nm-file.R#L142-L147

@seth127
Copy link
Collaborator

seth127 commented Oct 1, 2024

Thanks for this Kyle. For context, some downstream packages essentially treat integers as factors in some cases, and this change would address that issue.

@seth127
Copy link
Collaborator

seth127 commented Oct 1, 2024

Some added detail (that Kyle shared offline), as he notes, readr stopped doing "integer guessing" in readr 1.2.0 (released in 2018).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants