Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor render_scorecard_summary take advantage of performance improvements of summarize_package_results #4

Open
barrettk opened this issue Aug 7, 2023 · 0 comments

Comments

@barrettk
Copy link
Collaborator

barrettk commented Aug 7, 2023

render_scorecard_summary currently relies on build_risk_summary to build the risk summary dataframe.

The exported function summarize_package_results, used to rely on build_risk_summary as well, but was refactored to have significant performance improvements. render_scorecard_summary currently does not take advantage of these improvements. This is somewhat of a necessity when mapping over 1000 packages.

It's currently unclear if we will ditch build_risk_summary altogether, or just make it run summarize_package_results under the hood, and perform some additional operations to get it in the form render_scorecard_summary requires.

@barrettk barrettk added this to the First Release milestone Aug 7, 2023
@seth127 seth127 modified the milestones: First Release, Next Aug 10, 2023
@seth127 seth127 removed this from the Next milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants